(0.91.15) Make GPUAdaptedFieldTimeSeries an AbstractField with Nothing grid #3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad you could figure it out. Did you want me to test if this change removes the error? |
glwagner
changed the title
It would be great to put a test of this on ClimaOcean. We also need to test it here (but that's more work because we cano't use your MWE). |
simone-silvestri
approved these changes
Sep 25, 2024
|
@glwagner can the failures here be rerun, the PR otherwise should be fine now |
|
we got the dreaded exit status -1 |
|
Oh whoops this was the wrong compathrlper PR than the one I was thinking of, ignore me |
i suspected as much... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful because we get some methods, like
location.cc @francispoulin @simone-silvestri