Skip to content

Correct longitude bounds for ECCO2 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

simone-silvestri
Copy link
Collaborator

I was looking at ECCO2 while looking at #542 and realized that in the metadata refactor, the longitude bounds of the ECCO datasets were not correctly refactored.

This PR corrects it.

@simone-silvestri simone-silvestri requested a review from navidcy May 28, 2025 11:24
@simone-silvestri simone-silvestri changed the title Wrong longitude bounds for ECCO2 Correct longitude bounds for ECCO2 May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 14.28%. Comparing base (b53fcf1) to head (50281e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   14.29%   14.28%   -0.01%     
==========================================
  Files          48       48              
  Lines        2813     2814       +1     
==========================================
  Hits          402      402              
- Misses       2411     2412       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simone-silvestri simone-silvestri merged commit 4ab61a2 into main May 28, 2025
6 of 10 checks passed
@simone-silvestri simone-silvestri deleted the ss/fix-interfaces branch May 28, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants