A low resolution coupled simulation #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ss/one-degree-take3
…into ss/one-degree-take3
…into ss/one-degree-take3
|
maybe also delete the unused experiments |
glwagner
approved these changes
Feb 20, 2025
Yes please |
glwagner
reviewed
Feb 22, 2025
experiments/coupled_simulation/ocean_sea_ice_coupled_simulation.jl
Outdated
Show resolved
Hide resolved
glwagner
reviewed
Feb 22, 2025
experiments/coupled_simulation/ocean_sea_ice_coupled_simulation.jl
Outdated
Show resolved
Hide resolved
…nto ss/new-coupled-sim
|
Anyone knows what is the problem with GPU testing on the caltech cluster? @Sbozzolo @charleskawczynski |
We saw this elsewhere and other errors and was related to some issue on the system side. I'll open a ticket since this is still happening |
|
I ll force merge this because it is only blocked by the tests and still the coupling is not finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be a playground to test the fluxes in a simple setting.
This PR also fixes a couple of bugs in the interfaces and adds an
adjust_freezing_ocean_temperature!function, called on coupled model construction, that ensures that the initial ocean temperature is not below freezing, and sets the near-surface temperature to melting below sea ice