-
Notifications
You must be signed in to change notification settings - Fork 18
Allow attaching a prognostic atmosphere take 2 #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have added a clock to the time_step!(atmosphere, Δt)
interpolate_atmospheric_state!(coupled_model)
compute_net_atmosphere_fluxes!(coupled_model)
@inline thermodynamics_parameters(atmos) = ...
@inline reference_height(atmos) = ...
@inline boundary_layer_height(atmos) = ... |
makes sense. maybe somehow we can ensure synchronization of clocks somewhere since i guess everybody will have their own |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 35 35
Lines 2281 2284 +3
=====================================
- Misses 2281 2284 +3 ☔ View full report in Codecov by Sentry. |
Since the interface changed a bit it is easier to rewrite the PR rather than fix #322, since the changes are minimal. This PR supersedes #322 but has the same goal.
closes #322