Skip to content

Allow attaching a prognostic atmosphere take 2 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 15, 2025
Merged

Conversation

simone-silvestri
Copy link
Collaborator

Since the interface changed a bit it is easier to rewrite the PR rather than fix #322, since the changes are minimal. This PR supersedes #322 but has the same goal.

closes #322

@simone-silvestri simone-silvestri marked this pull request as ready for review February 15, 2025 16:23
@simone-silvestri
Copy link
Collaborator Author

I have added a clock to the PrescribedAtmosphere so we can remove the update_model_field_time_series!(atmosphere) from the update_state!(coupled_model) which means that we do not always have to extend update_model_field_time_series! for different atmospheric models, but only

time_step!(atmosphere, Δt)
interpolate_atmospheric_state!(coupled_model) 
compute_net_atmosphere_fluxes!(coupled_model)
@inline thermodynamics_parameters(atmos) = ...
@inline reference_height(atmos) = ...
@inline boundary_layer_height(atmos) = ...

@glwagner
Copy link
Member

makes sense. maybe somehow we can ensure synchronization of clocks somewhere since i guess everybody will have their own

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (5a3d6b4) to head (d9e6352).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/OceanSeaIceModels/PrescribedAtmospheres.jl 0.00% 9 Missing ⚠️
...OceanSeaIceModels/time_step_ocean_sea_ice_model.jl 0.00% 4 Missing ⚠️
src/OceanSeaIceModels/OceanSeaIceModels.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #342   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         35      35           
  Lines       2281    2284    +3     
=====================================
- Misses      2281    2284    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri simone-silvestri merged commit 220572d into main Feb 15, 2025
20 checks passed
@simone-silvestri simone-silvestri deleted the ss/time-step branch February 15, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants