Skip to content

An experiment to compute flux climatology #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 15, 2025

Conversation

simone-silvestri
Copy link
Collaborator

I have also added a prescribed ocean, so we have a completely prescribed earth model, where the only computation required are the fluxes

@simone-silvestri simone-silvestri marked this pull request as ready for review February 14, 2025 12:49
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8f87178) to head (51ffa37).

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO_restoring.jl 0.00% 3 Missing ⚠️
src/DataWrangling/ECCO/ECCO_metadata.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #340   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         35      35           
  Lines       2278    2281    +3     
=====================================
- Misses      2278    2281    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting implementation! I think this is nice.

I was wondering if a simpler approach would simply be to loop over a set of dates, update the model time, call set! to ECCO state on that date, and then call update_state!(coupled_model) to get the fluxes.

This approach is nice though because it's a little cheaper. And we may want a prescribed ocean too, esp for sea ice simulations...

@simone-silvestri
Copy link
Collaborator Author

I took the opportunity to check how difficult it would be to have a prescribed ocean in ClimaOcean. Apparently, not too difficult!

btw, these are the output of the script, ordered as:
(1) mean -> :balance
(2) std -> :deep
(3) max -> :magma
(4) min -> :haline
mean_fluxes
fluxes_std
fluxes_max
fluxes_min

@simone-silvestri simone-silvestri merged commit 5a3d6b4 into main Feb 15, 2025
6 of 8 checks passed
@simone-silvestri simone-silvestri deleted the ss/climatology-example branch February 15, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants