-
Notifications
You must be signed in to change notification settings - Fork 18
An experiment to compute flux climatology #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 35 35
Lines 2278 2281 +3
=====================================
- Misses 2278 2281 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, interesting implementation! I think this is nice.
I was wondering if a simpler approach would simply be to loop over a set of dates, update the model time, call set!
to ECCO state on that date, and then call update_state!(coupled_model)
to get the fluxes.
This approach is nice though because it's a little cheaper. And we may want a prescribed ocean too, esp for sea ice simulations...
I have also added a prescribed ocean, so we have a completely prescribed earth model, where the only computation required are the fluxes