Skip to content

Avoid extra step in computing turbulent fluxes #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Nov 19, 2024

Instead of converting twice (first ocean velocities then fluxes) between native and latlon grid, we can just convert once the atmosphere velocities to the native grid

@jm-c

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8057d1a) to head (30bd8d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Models/CrossRealmFluxes/atmosphere_ocean_fluxes.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #264   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         33      33           
  Lines       1873    1872    -1     
=====================================
+ Misses      1873    1872    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@simone-silvestri simone-silvestri added the build docs Add this label to built the docs in a PR label Nov 20, 2024
Copy link

@jm-c jm-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (but did not try to run this on Curvilinear grid).

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge!

@glwagner glwagner merged commit a4c405f into main Nov 21, 2024
23 checks passed
@simone-silvestri simone-silvestri deleted the ss/change-vector-rotation branch November 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build docs Add this label to built the docs in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants