Skip to content

More one degree simulation #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions experiments/one_degree_simulation/one_degree_simulation.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ using CUDA: @allowscalar, device!

using Oceananigans.Grids: znode

device!(3)
arch = GPU()

#####
Expand Down Expand Up @@ -47,7 +46,7 @@ grid = ImmersedBoundaryGrid(underlying_grid, GridFittedBottom(tampered_bottom_he

gm = Oceananigans.TurbulenceClosures.IsopycnalSkewSymmetricDiffusivity(κ_skew=1000, κ_symmetric=1000)
catke = ClimaOcean.OceanSimulations.default_ocean_closure()
viscous_closure = Oceananigans.TurbulenceClosures.HorizontalScalarDiffusivity(ν=10000)
viscous_closure = Oceananigans.TurbulenceClosures.HorizontalScalarDiffusivity(ν=2000)

closure = (gm, catke, viscous_closure)

Expand All @@ -74,7 +73,7 @@ forcing = (T=FT, S=FS)
#####

momentum_advection = VectorInvariant()
tracer_advection = Centered(order=2)
tracer_advection = WENO()

# Should we add a side drag since this is at a coarser resolution?
ocean = ocean_simulation(grid; momentum_advection, tracer_advection,
Expand All @@ -95,10 +94,10 @@ atmosphere = JRA55_prescribed_atmosphere(arch; backend=JRA55NetCDFBackend(20))
##### Coupled simulation
#####

sea_ice = ClimaOcean.OceanSeaIceModels.MinimumTemperatureSeaIce()
coupled_model = OceanSeaIceModel(ocean, sea_ice; atmosphere, radiation)
# similarity = SimilarityTheoryTurbulentFluxes(grid; gustiness_parameter = 0.5)
coupled_model = OceanSeaIceModel(ocean; atmosphere, radiation) #, similarity_theory = similarity)

simulation = Simulation(coupled_model; Δt=15minutes, stop_time=2*365days)
simulation = Simulation(coupled_model; Δt=1minutes, stop_time=2*365days, stop_iteration=1)

#####
##### Run it!
Expand Down
2 changes: 2 additions & 0 deletions src/DataWrangling/ECCO/ECCO.jl
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ function ECCO_field(metadata::ECCOMetadata;
copyto!(parent(field), data)
return field
end

close(file)
end

download_dataset(metadata)
Expand Down
2 changes: 1 addition & 1 deletion src/DataWrangling/inpaint_mask.jl
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ Arguments
- `inpainting`: The inpainting algorithm to use. For the moment, the only option is `NearestNeighborInpainting(maxiter)`,
where an average of the valid surrounding values is used `maxiter` times.
"""
function inpaint_mask!(field, mask; inpainting=NearestNeighborInpainting(10))
function inpaint_mask!(field, mask; inpainting=NearestNeighborInpainting(Inf))

if inpainting isa Int
inpainting = NearestNeighborInpainting(inpainting)
Expand Down
Loading