Skip to content

Run the hello-global-ocean example in Docs #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 29, 2025
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented May 24, 2025

No description provided.

@navidcy navidcy added documentation Improvements or additions to documentation build docs Add this label to built the docs in a PR labels May 24, 2025
@glwagner
Copy link
Member

yah! because we run on tartarus now!

@navidcy
Copy link
Member Author

navidcy commented May 25, 2025

Seems to hit memory limit during _regrid_bathymetry.

https://buildkite.com/clima/climaocean-examples/builds/3616#01970580-c7f2-4c14-8b04-fde27ba22888/22-1364

Hm...

@navidcy
Copy link
Member Author

navidcy commented May 25, 2025

Somehow it's trying to create the ETOPO native grid on the GPU!

@navidcy
Copy link
Member Author

navidcy commented May 25, 2025

I'm wondering why we don't hit the same issue with the near-global example

@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

I guess it's a bit too much memory-wise?

https://buildkite.com/clima/climaocean-examples/builds/3616#01971502-890d-4ffd-bac1-e0dd01785b78/23-1400

I'm wondering if some of the defaults trigger bigger memory allocation than the near-global case in the examples.

I'm closing the PR. Feel free to re-open or we can try later?

@navidcy navidcy closed this May 28, 2025
@simone-silvestri
Copy link
Collaborator

Probably the issue is that we are overloading the (smallish) Tartarus GPU with the examples?

@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

hm.... perhaps.... I'm trying to run the hello-global-ocean on tartarus at the moment (just in the REPL) to see if it goes through.

@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

btw, I run the README hello-global-ocean example on tartarus on main and got this plot:

hello-global-ocean

Looks really strange isn't it?

cc @simone-silvestri, @glwagner

@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

@glwagner you sure you didn't use higher vertical resolution for the image we have in the README?
Or perhaps some defaults changed?

The snapshot I got looks really bad compared with the one in the README...

@simone-silvestri
Copy link
Collaborator

The difference is the initial conditions I think. In the README we were starting from ECCO2 which is eddying, then the default changed to ECCO4 that is not eddying, so no eddies in that small integration time.

@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

oh I can change that and try again! thanks!
and if so, I'll fix the README example

@navidcy navidcy reopened this May 28, 2025
@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

hm... before the Metadata refactor the README was initialised with ECCOMetadata which had ECCO4Monthly() as default:

version = ECCO4Monthly(),

But I'll try with ECCO2 and see if it's different.

@simone-silvestri
Copy link
Collaborator

Nono, that change was much before the Metadata refactor

@navidcy
Copy link
Member Author

navidcy commented May 28, 2025

OK great. I'll run with ECCO2!

@simone-silvestri
Copy link
Collaborator

simone-silvestri commented May 28, 2025

See this PR: 887bc46
ECCO2Daily was the default metadata for ECCO

@navidcy
Copy link
Member Author

navidcy commented May 29, 2025

ok, reproduced this:
hello-global-ocean-ecco2daily

@navidcy
Copy link
Member Author

navidcy commented May 29, 2025

docs with the example at https://clima.github.io/ClimaOceanDocumentation/previews/PR542/

@navidcy navidcy merged commit 3360293 into main May 29, 2025
21 checks passed
@navidcy navidcy deleted the ncc/run-hello-global-ocean branch May 29, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build docs Add this label to built the docs in a PR documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants