Creating function to be able to run run_fluxnet for any fluxnet site with generic parameters #1182
Conversation
ThanhNguyen428
force-pushed
the
tn/any_fluxnet_site_empty_list
branch
3 times, most recently
from
a630178 to
1cb4760
Compare
|
This is looking good! I will review in a moment, but it would also be good to: 1. rebase on current main, and 2. not modify the Manifest in this PR - to do this you can check out the Manifest from main by running |
…nctions from any_run_fluxnet
pick 1cb4760 deprecated run_fluxnet.jl to become a pure simulation file calling functions from any_run_fluxnet
| ), | ||
| ) | ||
|
|
||
| Base.invokelatest(run_helper, site_ID, params) |
There was a problem hiding this comment.
We shouldn't need to call Base.invokelatest, and if we remove it we'll be able to get rid of the @eval macro in run_helper
|
|
||
| sol = SciMLBase.solve(prob, ode_algo; dt = dt, callback = cb) | ||
|
|
||
| # Extract model output from the saved diagnostics |
There was a problem hiding this comment.
Everything from here down in this function can go into another function postprocess_fluxnet(), so that we can run the simulation without postprocessing (e.g. for calibration), and also to make the code more readable
| if isfile( | ||
| joinpath( | ||
| climaland_dir, | ||
| "experiments/integrated/fluxnet/$site_ID/Artifacts.toml", | ||
| ), | ||
| ) | ||
| rm( | ||
| joinpath( | ||
| climaland_dir, | ||
| "experiments/integrated/fluxnet/$site_ID/Artifacts.toml", | ||
| ), | ||
| ) | ||
| end |
There was a problem hiding this comment.
this would be more concise:
| if isfile( | |
| joinpath( | |
| climaland_dir, | |
| "experiments/integrated/fluxnet/$site_ID/Artifacts.toml", | |
| ), | |
| ) | |
| rm( | |
| joinpath( | |
| climaland_dir, | |
| "experiments/integrated/fluxnet/$site_ID/Artifacts.toml", | |
| ), | |
| ) | |
| end | |
| artifact_file = joinpath(climaland_dir, "experiments/integrated/fluxnet/$site_ID/Artifacts.toml") | |
| isfile(artifact_file) && rm(artifact_file) |
ThanhNguyen428
force-pushed
the
tn/any_fluxnet_site_empty_list
branch
from
43c662e to
2aa009f
Compare
Purpose
Added function to allow run_fluxnet.jl to be extrapolated for a fixed set of params and any fluxnet site (stored in any_run_fluxnet.jl). Was tested with US-Ha1 to confirm that it is working.
To-do
Content