Prevent mask from being incorrectly used when Remapping on a non-supported space #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Remapping.Remapper` performs spectral interpolation. When interpolating, every point in a given element is used to calculate the target value. As a result, the result is incorrect if one or more of the nodes in an element are masked. This commit prevents users from accidentally obtaining subtly incorrect results by calling the Remapper on a space that is not supported. Note that if none of the nodes in an element are masked, the interpolation routine would be fine. A more refined implementation of this check could take this into consideration.
Sbozzolo
changed the title
Sbozzolo
changed the title
charleskawczynski
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remapping.Remapperperforms spectral interpolation. When interpolating, every point in a given element is used to calculate the target value. As a result, the result is incorrect if one or more of the nodes in an element are masked.This commit prevents users from accidentally obtaining subtly incorrect results by calling the Remapper on a space that is not supported.
Note that if none of the nodes in an element are masked, the interpolation routine would be fine. A more refined implementation of this check could take this into consideration, but this is deferred to when such need arises.