Skip to content

Cc/test lazy level precomputed2 #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

costachris
Copy link
Member

No description provided.

tapios and others added 7 commits July 17, 2025 10:57
Remove from ᶜρa⁰

Fixed syntax errors

Removed ᶜρ⁰ from precomputed

Remove ᶜq_tot⁰ (and fix forgotten ᶜρa⁰

Introduced helper functions to compute sums over draft, environmental volumetric variables, and specific env variables

Use new helper functions to simplify calculation of ᶜq_tot⁰

Remove redundant draft sum functions

Added specific_env_mse helper

Removed ᶜmse⁰ from precomputed

Remove ᶜq_liq⁰, ᶜq_ice⁰, ᶜq_rai⁰, ᶜq_sno⁰ from precomputed

Remove redundant draft sum helper functions; docstrings

Added TODO

Renamed specific_gs to all_specific_gs; specific_sgs to all_specific_sgs; added docstrings

Added new helper specific_sgs to cleanly extract specific SGS quantities; use it to get env TKE

Change specific_sgs to use ClimaCore>MatrixFIelds for type stability

Removed ᶜspecific (GS precomputed specific quantities); caveat lector [lots of changes]

Correcting errors in previous commit removing gs precomputed quantities

Removed a few more instances of ᶜspecific from precomputed quantities; removed ᶜtke⁰

Missing ᶜtke⁰ removal

Another ᶜtke⁰ fix

Introduced helper function for specific_tke and used it where needed

Corrections of rebasing mistakes; updates to variable_manipulations for clarity.

Removing some more ᶜspecific

Added ᶜtke⁰ computations

Removal of more specifics

Remove h_tot

Syntax corrections

Fixes in cloud fraction

Syntax error fix in jacobian

Remove specific in precomputed_quantities; syntax error corrections
@costachris costachris closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants