-
Notifications
You must be signed in to change notification settings - Fork 23
Sa/add aerosol activation #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3f12ff2
to
b3eb3c5
Compare
8b62879
to
9c0eefc
Compare
…r 2M microphysics
9c0eefc
to
f438d40
Compare
seasalt_num, | ||
seasalt_mean_radius, | ||
sulfate_num, | ||
specific(Y.c.ρq_tot, Y.c.ρ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what moisture and precipitation configurations this will be tested?
If we are aiming to swap out the 1M for the 2M scheme, then we should be passing q_tot, q_liq, q_ice, q_rai and q_sno. Precipitation is part of the working fluid, so q_vap = q_tot - q_liq - q_ice - q_rai - q_sno.
dt, | ||
) | ||
# Aerosol activation using prescribed aerosol (Sea salt and sulfate) | ||
if !(:prescribed_aerosols_field in propertynames(p.tracers)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for prescribed_aerosols_field
to not be empty, but not contain any of the seasalt or sulfate aerosol fields you are expecting?
@. seasalt_num += seasalt_mass / seasalt_particle_mass | ||
@. seasalt_mean_radius += | ||
seasalt_mass / seasalt_particle_mass * | ||
log(seasalt_particle_radius) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there log
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I guess I just dont understand how the mean radius is computed here
aerosol_params = cmc.aerosol | ||
T = Tₐ(thermo_params, ts) | ||
p = Pₐ(thermo_params, ts) | ||
S = CMTDI.supersaturation_over_liquid(thermo_params, qₜ, qₗ, qᵢ, ρ, T) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here q_l should be equal to q_lcl + q_rai and q_i = q_icl + q_sno
Left some small comments:
Thank you! |
Purpose
Add aerosol activation based on Abdulrazzak and Ghan (2000).
To-do
Add a good test
Content