Skip to content

Conversation

@abcdvvvv
Copy link
Contributor

@abcdvvvv abcdvvvv commented Oct 17, 2025

… to phase boundaries using a small threshold.

FlashResult: update show to print per-phase moles as n (instead of β) to avoid confusion.

Performance enhancement: @view(x[in_equilibria]) may create a non-contiguous (scattered) view, which degrades performance, so we precompute an index vector equilibria_idx for in_equilibria and switch to an explicit element-wise loop to maximize performance

… to phase boundaries using a small threshold.

FlashResult: update `show` to print per-phase amount as `n` (instead of `β`) to avoid confusion.
@abcdvvvv
Copy link
Contributor Author

#465

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.04%. Comparing base (7e77779) to head (a7c69a7).

Files with missing lines Patch % Lines
...c/methods/property_solvers/multicomponent/flash.jl 0.00% 2 Missing ⚠️
...lvers/multicomponent/tp_flash/Michelsentp_flash.jl 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   76.08%   76.04%   -0.04%     
==========================================
  Files         364      362       -2     
  Lines       31179    31095      -84     
==========================================
- Hits        23723    23647      -76     
+ Misses       7456     7448       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant