Adjusts parser for "show ap cdp neighbor" #948
Conversation
Resolves CiscoTestAutomation#723 Adjust regex to include the ap neighbor IP as it is output on 9800 platform v17.x
There was a problem hiding this comment.
Thank you for your contribution.
A few things
-
Please include a unittest for this change. You can find existing unittests for this parser here
-
While I won't hold it against you, since you're updating this parser anyways I would appreciate if you could update line 1152 from
Optional("neighbor_ip_addresses"): listtoOptional("neighbor_ip_addresses"): ListOf(str)as it's a bit out of date for what we expect from a parser these days
|
Thank you @ThomasJRyan, and apologies for the delay in response. I have pushed some additional commits that (hopefully correctly) addresses your feedback. Please let me know :) |
|
Looks like your changes are causing existing unittests to fail.
This will need to be fixed up before we can merge. You can run the unittests locally by going into the |
Description
Resolves #723
Adjust regex to include the ap neighbor IP as it is output on 9800 platform v17.x
Motivation and Context
The parser fails as it's not able to match when the ap cdp neighbor IP is in the same line as the other information.