[cleanup] Enable noUnusedParameters in tsconfig

This should help when refactoring to not include code that is not used

Bug: 409278895
Change-Id: I5d11ab271f0d3c1c71deacd4eff1c2fbd64a8e40
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450579
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

Author: Lightning00Blade

config/typescript/tsconfig.base.json

@@ -11,6 +11,7 @@
 
     "strict": true,
     "useUnknownInCatchVariables": false,
+    "noUnusedParameters": true,
     "noUnusedLocals": false,
     "noImplicitReturns": true,
     "noImplicitOverride": true,

front_end/models/trace/Processor.test.ts

@@ -266,7 +266,7 @@ describeWithEnvironment('TraceProcessor', function() {
             UIStrings: {} as any,
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
             i18nString: (() => {}) as any,
-            isRenderBlocking: (x: unknown): x is Trace.Insights.Models.RenderBlocking.RenderBlockingInsightModel =>
+            isRenderBlocking: (_x: unknown): _x is Trace.Insights.Models.RenderBlocking.RenderBlockingInsightModel =>
                 false,
             generateInsight: () => {
               throw new Error('forced error');

front_end/models/workspace/UISourceCode.test.ts

@@ -119,7 +119,7 @@ describe('UISourceCode', () => {
     const sutObject = setupMockedUISourceCode();
     sutObject.projectStub.workspace.returns(sinon.createStubInstance(Workspace.Workspace.WorkspaceImpl));
     const rawPathstringExample = 'newName.html' as Platform.DevToolsPath.RawPathString;
-    sutObject.projectStub.rename.callsFake((uiSourceCode, rawPathstringExample, innerCallback) => {
+    sutObject.projectStub.rename.callsFake((_uiSourceCode, rawPathstringExample, innerCallback) => {
       innerCallback(true, rawPathstringExample);
     });
 

front_end/panels/ai_assistance/SelectWorkspaceDialog.ts

@@ -95,7 +95,7 @@ export class SelectWorkspaceDialog extends UI.Widget.VBox {
     }
 
     // clang-format off
-    this.#view = view ?? ((input, output, target) => {
+    this.#view = view ?? ((input, _output, target) => {
       const hasFolders = input.folders.length > 0;
       render(
         html`

front_end/panels/application/AppManifestView.ts

@@ -1107,8 +1107,7 @@ export class AppManifestView extends Common.ObjectWrapper.eventMixin<EventTypes,
   }
 
   checkSizeProblem(
-      size: ParsedSize, type: string|undefined, image: HTMLImageElement,
-      resourceName: Platform.UIString.LocalizedString,
+      size: ParsedSize, image: HTMLImageElement, resourceName: Platform.UIString.LocalizedString,
       imageUrl: string): {error?: Platform.UIString.LocalizedString, hasSquareSize: boolean} {
     if ('any' in size) {
       return {hasSquareSize: image.naturalWidth === image.naturalHeight};
@@ -1186,8 +1185,7 @@ export class AppManifestView extends Common.ObjectWrapper.eventMixin<EventTypes,
         imageResourceErrors.push(i18nString(UIStrings.screenshotPixelSize, {url: imageUrl}));
       }
       for (const size of sizes) {
-        const {error, hasSquareSize} =
-            this.checkSizeProblem(size, imageResource['type'], image, resourceName, imageUrl);
+        const {error, hasSquareSize} = this.checkSizeProblem(size, image, resourceName, imageUrl);
         squareSizedIconAvailable = squareSizedIconAvailable || hasSquareSize;
         if (error) {
           imageResourceErrors.push(error);

front_end/panels/application/ServiceWorkerCacheViews.ts

@@ -315,9 +315,7 @@ export class ServiceWorkerCacheView extends UI.View.SimpleView {
     }
   }
 
-  private updateDataCallback(
-      this: ServiceWorkerCacheView, skipCount: number, entries: Protocol.CacheStorage.DataEntry[],
-      returnCount: number): void {
+  private updateDataCallback(entries: Protocol.CacheStorage.DataEntry[], returnCount: number): void {
     if (!this.dataGrid) {
       return;
     }
@@ -377,7 +375,7 @@ export class ServiceWorkerCacheView extends UI.View.SimpleView {
     });
 
     const {entries, returnCount} = await this.loadingPromise;
-    this.updateDataCallback(0, entries, returnCount);
+    this.updateDataCallback(entries, returnCount);
     this.loadingPromise = null;
     return;
   }

front_end/panels/application/SharedStorageItemsView.ts

@@ -138,7 +138,7 @@ export class SharedStorageItemsView extends KeyValueStorageItemsView {
     UI.ARIAUtils.alert(i18nString(UIStrings.sharedStorageFilteredItemsCleared));
   }
 
-  protected override isEditAllowed(columnIdentifier: string, oldText: string, newText: string): boolean {
+  protected override isEditAllowed(columnIdentifier: string, _oldText: string, newText: string): boolean {
     if (columnIdentifier === 'key' && newText === '') {
       // The Shared Storage backend does not currently allow '' as a key, so we only set a new entry with a new key if its new key is nonempty.
       void this.refreshItems().then(() => {

front_end/panels/console/ConsoleViewMessage.test.ts

@@ -279,14 +279,14 @@ describeWithMockConnection('ConsoleViewMessage', () => {
           stackTraceMessage, messageDetails);
       const {message, linkifier} = createConsoleViewMessageWithStubDeps(rawMessage);
 
-      linkifier.linkifyScriptLocation.callsFake((target, scriptId, sourceURL, lineNumber, options) => {
+      linkifier.linkifyScriptLocation.callsFake((_target, _scriptId, sourceURL, lineNumber, options) => {
         const link = Components.Linkifier.Linkifier.linkifyURL(sourceURL, {lineNumber, ...options});
         if (ignoreListFn(sourceURL)) {
           link.classList.add(IGNORE_LIST_LINK);
         }
         return link;
       });
-      linkifier.maybeLinkifyConsoleCallFrame.callsFake((target, callFrame, options) => {
+      linkifier.maybeLinkifyConsoleCallFrame.callsFake((_target, callFrame, options) => {
         const link = Components.Linkifier.Linkifier.linkifyURL(
             urlString`${callFrame.url}`, {lineNumber: callFrame.lineNumber, ...options});
         if (ignoreListFn(callFrame.url)) {

front_end/panels/elements/StylePropertyTreeElement.test.ts

@@ -50,7 +50,7 @@ describeWithMockConnection('StylePropertyTreeElement', () => {
     matchedStyles = await getMatchedStylesWithBlankRule(
         new SDK.CSSModel.CSSModel(createTarget()), undefined, {startLine: 0, startColumn: 0, endLine: 0, endColumn: 1});
     sinon.stub(matchedStyles, 'availableCSSVariables').returns(Object.keys(mockVariableMap));
-    fakeComputeCSSVariable = sinon.stub(matchedStyles, 'computeCSSVariable').callsFake((style, name) => {
+    fakeComputeCSSVariable = sinon.stub(matchedStyles, 'computeCSSVariable').callsFake((_style, name) => {
       return {
         value: mockVariableMap[name],
         declaration: new SDK.CSSMatchedStyles.CSSValueSource(sinon.createStubInstance(SDK.CSSProperty.CSSProperty)),
@@ -1575,7 +1575,7 @@ describeWithMockConnection('StylePropertyTreeElement', () => {
   });
 
   describe('CSSWideKeywordRenderer', () => {
-    function mockResolvedKeyword(propertyName: string, keyword: SDK.CSSMetadata.CSSWideKeyword, propertyValue = ''):
+    function mockResolvedKeyword(propertyName: string, _keyword: SDK.CSSMetadata.CSSWideKeyword, propertyValue = ''):
         sinon.SinonStubbedInstance<SDK.CSSProperty.CSSProperty> {
       const originalDeclaration = sinon.createStubInstance(SDK.CSSProperty.CSSProperty);
       sinon.stub(matchedStyles, 'resolveGlobalKeyword')

front_end/panels/protocol_monitor/ProtocolMonitor.test.ts

@@ -481,7 +481,7 @@ describeWithEnvironment('view', () => {
       targets: [],
       selectedTargetId: 'main',
     };
-    const viewOutput = {set editorWidget(value: ProtocolMonitor.JSONEditor.JSONEditor) {}};
+    const viewOutput = {set editorWidget(_value: ProtocolMonitor.JSONEditor.JSONEditor) {}};
 
     view(viewInput, viewOutput, target);
     await assertScreenshot('protocol_monitor/basic.png');
@@ -538,7 +538,7 @@ describeWithEnvironment('view', () => {
       ] as SDK.Target.Target[],
       selectedTargetId: 'prerender',
     };
-    const viewOutput = {set editorWidget(value: ProtocolMonitor.JSONEditor.JSONEditor) {}};
+    const viewOutput = {set editorWidget(_value: ProtocolMonitor.JSONEditor.JSONEditor) {}};
 
     view(viewInput, viewOutput, target);
     await assertScreenshot('protocol_monitor/advanced.png');

front_end/panels/sources/SourcesView.test.ts

@@ -56,7 +56,7 @@ describeWithEnvironment('SourcesView', () => {
     });
     project.canSetFileContent = () => true;
     project.rename =
-        (uiSourceCode: Workspace.UISourceCode.UISourceCode, newName: string,
+        (_uiSourceCode: Workspace.UISourceCode.UISourceCode, newName: string,
          callback: (
              arg0: boolean, arg1?: string, arg2?: Platform.DevToolsPath.UrlString,
              arg3?: Common.ResourceType.ResourceType) => void) => {

front_end/panels/sources/components/BreakpointsView.test.ts

@@ -1205,8 +1205,7 @@ describeWithMockConnection('BreakpointsView', () => {
   });
 
   describe('group checkboxes', () => {
-    async function waitForCheckboxToggledEventsWithCheckedUpdate(
-        component: SourcesComponents.BreakpointsView.BreakpointsView, numBreakpointItems: number, checked: boolean) {
+    async function waitForCheckboxToggledEventsWithCheckedUpdate(numBreakpointItems: number, checked: boolean) {
       return await new Promise<void>(resolve => {
         let numCheckboxToggledEvents = 0;
         const controller = SourcesComponents.BreakpointsView.BreakpointsSidebarController.instance();
@@ -1284,7 +1283,7 @@ describeWithMockConnection('BreakpointsView', () => {
       assert.instanceOf(groupCheckbox, HTMLInputElement);
 
       // Wait until we receive all events fired that notify us of disabled breakpoints.
-      const waitForEventPromise = waitForCheckboxToggledEventsWithCheckedUpdate(component, numBreakpointItems, false);
+      const waitForEventPromise = waitForCheckboxToggledEventsWithCheckedUpdate(numBreakpointItems, false);
 
       groupCheckbox.click();
       await waitForEventPromise;
@@ -1313,7 +1312,7 @@ describeWithMockConnection('BreakpointsView', () => {
       assert.instanceOf(groupCheckbox, HTMLInputElement);
 
       // Wait until we receive all events fired that notify us of enabled breakpoints.
-      const waitForEventPromise = waitForCheckboxToggledEventsWithCheckedUpdate(component, numBreakpointItems, true);
+      const waitForEventPromise = waitForCheckboxToggledEventsWithCheckedUpdate(numBreakpointItems, true);
 
       groupCheckbox.click();
       await waitForEventPromise;

front_end/panels/timeline/TimelineFlameChartView.ts

@@ -1869,7 +1869,7 @@ export class TimelineFlameChartMarker implements PerfUI.FlameChart.FlameChartMar
     return i18nString(UIStrings.sAtS, {PH1: this.style.title, PH2: startTime});
   }
 
-  draw(context: CanvasRenderingContext2D, x: number, height: number, pixelsPerMillisecond: number): void {
+  draw(context: CanvasRenderingContext2D, x: number, _height: number, pixelsPerMillisecond: number): void {
     const lowPriorityVisibilityThresholdInPixelsPerMs = 4;
 
     if (this.style.lowPriority && pixelsPerMillisecond < lowPriorityVisibilityThresholdInPixelsPerMs) {

front_end/testing/ExpectStubCall.ts

@@ -29,7 +29,7 @@ export function expectCalled<TArgs extends any[] = any[], TReturnValue = any>(
 }
 
 type Args<T> = T extends(...args: infer TArgs) => unknown ? TArgs : never;
-type Ret<T> = T extends(...args: infer TArgs) => infer TRet ? TRet : never;
+type Ret<T> = T extends(...args: any[]) => infer TRet ? TRet : never;
 
 export function spyCall<T, Fn extends keyof T>(obj: T, method: Fn): Promise<{args: Args<T[Fn]>, result: Ret<T[Fn]>}> {
   const {promise, resolve} = Promise.withResolvers<{args: Args<T[Fn]>, result: Ret<T[Fn]>}>();

front_end/testing/MockExecutionContext.ts

@@ -16,7 +16,7 @@ export class MockExecutionContext extends SDK.RuntimeModel.ExecutionContext {
     super(runtimeModel, 1 as Protocol.Runtime.ExecutionContextId, 'test id', 'test name', urlString`test origin`, true);
   }
 
-  override async evaluate(options: SDK.RuntimeModel.EvaluationOptions, userGesture: boolean, _awaitPromise: boolean):
+  override async evaluate(_options: SDK.RuntimeModel.EvaluationOptions, userGesture: boolean, _awaitPromise: boolean):
       Promise<SDK.RuntimeModel.EvaluationResult> {
     assert.isTrue(userGesture);
     return {error: 'test'};

front_end/ui/components/docs/survey_link/basic.ts

@@ -19,10 +19,10 @@ document.getElementById('container')?.appendChild(link);
 link.data = {
   trigger: 'test trigger',
   promptText: Common.UIString.LocalizedEmptyString,
-  canShowSurvey: (trigger, callback) => {
+  canShowSurvey: (_trigger, callback) => {
     setTimeout(callback.bind(undefined, {canShowSurvey: true}), 500);
   },
-  showSurvey: (trigger, callback) => {
+  showSurvey: (_trigger, callback) => {
     setTimeout(callback.bind(undefined, {surveyShown: true}), 1500);
   },
 };

front_end/ui/components/survey_link/SurveyLink.test.ts

@@ -8,16 +8,16 @@ import {describeWithLocale} from '../../../testing/EnvironmentHelpers.js';
 
 import * as SurveyLink from './survey_link.js';
 
-function canShowSuccessfulCallback(trigger: string, callback: SurveyLink.SurveyLink.CanShowSurveyCallback) {
+function canShowSuccessfulCallback(_trigger: string, callback: SurveyLink.SurveyLink.CanShowSurveyCallback) {
   callback({canShowSurvey: true});
 }
-function showSuccessfulCallback(trigger: string, callback: SurveyLink.SurveyLink.ShowSurveyCallback) {
+function showSuccessfulCallback(_trigger: string, callback: SurveyLink.SurveyLink.ShowSurveyCallback) {
   callback({surveyShown: true});
 }
-function canShowFailureCallback(trigger: string, callback: SurveyLink.SurveyLink.CanShowSurveyCallback) {
+function canShowFailureCallback(_trigger: string, callback: SurveyLink.SurveyLink.CanShowSurveyCallback) {
   callback({canShowSurvey: false});
 }
-function showFailureCallback(trigger: string, callback: SurveyLink.SurveyLink.ShowSurveyCallback) {
+function showFailureCallback(_trigger: string, callback: SurveyLink.SurveyLink.ShowSurveyCallback) {
   callback({surveyShown: false});
 }
 

front_end/ui/legacy/Toolbar.ts

@@ -905,7 +905,7 @@ class ToolbarInputElement extends HTMLElement {
     return [...options].map((({value}) => value)).filter(value => value.startsWith(prefix)).map(text => ({text}));
   }
 
-  attributeChangedCallback(name: string, oldValue: string, newValue: string): void {
+  attributeChangedCallback(name: string, _oldValue: string, newValue: string): void {
     if (name === 'value') {
       if (this.item && this.item.value() !== newValue) {
         this.item.setValue(newValue, true);

scripts/eslint_rules/lib/no-imperative-dom-api/toolbar.ts

@@ -26,7 +26,7 @@ export const toolbar = {
                 return null;
             }
           },
-      methodCall(property: Node, firstArg: Node, secondArg: Node, domFragment: DomFragment, _call: Node): boolean {
+      methodCall(property: Node, firstArg: Node, _secondArg: Node, domFragment: DomFragment, _call: Node): boolean {
         if (isIdentifier(property, 'appendToolbarItem')) {
           domFragment.appendChild(firstArg, sourceCode);
           return true;