Skip to content

Commit b5a044f

Browse files
petrcermakDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
[tracing] Prepare Devtools for moving ChromeFrameReporter definition
Chrome Devtools are preventing https://crrev.com/c/6243825 from being submitted because they have a dependency on ChromeTrackEvent.chrome_frame_reporter, which is being replaced with ChromeTrackEvent.frame_reporter. This CL modifies Devtools to support both fields. Bug: 409484302 Change-Id: Ibe0fe799e45af57002b2f2e12377be543bc26205 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441450 Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Petr Cermak <petrcermak@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org> Auto-Submit: Petr Cermak <petrcermak@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org>
1 parent e12ae49 commit b5a044f

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

front_end/models/trace/handlers/ScreenshotsHandler.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ export async function finalize(): Promise<void> {
3838
const pipelineReporterEvents = Helpers.Trace.createMatchedSortedSyntheticEvents(unpairedAsyncEvents);
3939

4040
frameSequenceToTs = Object.fromEntries(pipelineReporterEvents.map(evt => {
41-
const frameSequenceId = evt.args.data.beginEvent.args.chrome_frame_reporter.frame_sequence;
41+
const args = evt.args.data.beginEvent.args;
42+
const frameReporter = 'frame_reporter' in args ? args.frame_reporter : args.chrome_frame_reporter;
43+
const frameSequenceId = frameReporter.frame_sequence;
4244
const presentationTs = Types.Timing.Micro(evt.ts + evt.dur);
4345
return [frameSequenceId, presentationTs];
4446
}));

front_end/models/trace/types/TraceEvents.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1540,14 +1540,22 @@ const enum FrameType {
15401540
BACKFILL = 'BACKFILL',
15411541
}
15421542

1543+
// TODO(crbug.com/409484302): Remove once Chrome migrates from
1544+
// ChromeTrackEvent.chrome_frame_reporter to ChromeTrackEvent.frame_reporter.
1545+
export interface OldChromeFrameReporterArgs {
1546+
chrome_frame_reporter: ChromeFrameReporter;
1547+
}
1548+
1549+
export interface NewChromeFrameReporterArgs {
1550+
frame_reporter: ChromeFrameReporter;
1551+
}
1552+
15431553
export interface PipelineReporter extends Event {
15441554
id2?: {
15451555
local?: string,
15461556
};
15471557
ph: Phase.ASYNC_NESTABLE_START|Phase.ASYNC_NESTABLE_END;
1548-
args: Args&{
1549-
chrome_frame_reporter: ChromeFrameReporter,
1550-
};
1558+
args: Args&(OldChromeFrameReporterArgs|NewChromeFrameReporterArgs);
15511559
}
15521560

15531561
export function isPipelineReporter(event: Event): event is PipelineReporter {

0 commit comments

Comments
 (0)