Skip to content

Conversation

@bacelarfc
Copy link
Collaborator

@bacelarfc bacelarfc commented Apr 4, 2025

This pull request introduces a new feature for exporting artifacts to JSON files and includes several changes across multiple files to support this functionality. The most important changes include modifications to the configuration structure, updates to the program logic, and the addition of a new package for handling the export process.

Configuration Updates:

  • internal/bootstrap/viper.go: Added a new Export section to the configuration structure, including an Artifacts subsection with Enabled and Folder fields. Set default values for these new fields. [1] [2] [3]

Program Logic Updates:

  • internal/program.go: Updated the program function to include a step for exporting artifacts to JSON if the feature is enabled. Added the necessary import for the new exportArtifacts package. [1] [2]

New Export Artifacts Package:

  • pkg/exportArtifacts/main.go: Created a new package exportArtifacts with a struct ExportOption and a method Run to handle the export of image and chart data to a JSON file.
  • pkg/exportArtifacts/main_test.go: Added tests for the exportArtifacts package to ensure the export functionality works correctly and creates the expected JSON file.

@bacelarfc bacelarfc changed the title [Feat] Output artifacts overview to json [feat] Output artifacts overview to json Apr 4, 2025
@ChristofferNissen ChristofferNissen marked this pull request as ready for review April 7, 2025 12:14
@ChristofferNissen ChristofferNissen self-requested a review as a code owner April 7, 2025 12:14
@ChristofferNissen
Copy link
Owner

Hey 👋
Looks good so far. We are missing the new feature described in the docs:

  1. Add entry to configuration table and example
  2. Would be cool with an intro example without import but only export

@bacelarfc bacelarfc requested a review from kuznero April 10, 2025 11:10
@bacelarfc bacelarfc merged commit ef1c2c8 into main Apr 11, 2025
6 checks passed
ChristofferNissen added a commit that referenced this pull request Apr 11, 2025
…to-json

    [feat] output artifacts overview to json
@ChristofferNissen ChristofferNissen deleted the feat/output-artifacts-to-json branch June 3, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants