-
Notifications
You must be signed in to change notification settings - Fork 18
[feat] Output artifacts overview to json #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey 👋
|
kuznero
requested changes
Apr 7, 2025
kuznero
reviewed
Apr 9, 2025
ChristofferNissen
approved these changes
Apr 10, 2025
kuznero
approved these changes
Apr 11, 2025
ChristofferNissen
added a commit
that referenced
this pull request
Apr 11, 2025
…to-json
[feat] output artifacts overview to json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature for exporting artifacts to JSON files and includes several changes across multiple files to support this functionality. The most important changes include modifications to the configuration structure, updates to the program logic, and the addition of a new package for handling the export process.
Configuration Updates:
internal/bootstrap/viper.go: Added a newExportsection to the configuration structure, including anArtifactssubsection withEnabledandFolderfields. Set default values for these new fields. [1] [2] [3]Program Logic Updates:
internal/program.go: Updated theprogramfunction to include a step for exporting artifacts to JSON if the feature is enabled. Added the necessary import for the newexportArtifactspackage. [1] [2]New Export Artifacts Package:
pkg/exportArtifacts/main.go: Created a new packageexportArtifactswith a structExportOptionand a methodRunto handle the export of image and chart data to a JSON file.pkg/exportArtifacts/main_test.go: Added tests for theexportArtifactspackage to ensure the export functionality works correctly and creates the expected JSON file.