Skip to content

[feat] add version template for the modify config option #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[feat] add version template for the modify config option #120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22e6837
add feat to introduce a version template for the modify config option
ChristofferNissen Oct 16, 2024
61d9a98
remove extra space from string
ChristofferNissen Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/program.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ func Program(args []string) error {
}
for _, modify := range c.Images.Modify {
if modify.From != "" {

if strings.HasPrefix(r, modify.From) {
delete(m, i)

Expand Down
6 changes: 5 additions & 1 deletion pkg/helm/chartOption.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,11 @@ func (co ChartOption) Run(ctx context.Context, setters ...Option) (ChartData, er
for _, mod := range c.Images.Modify {
if mod.FromValuePath != "" {
slog.Info("modifying chart value", slog.String("HelmValuesPath", mod.FromValuePath), slog.String("new", mod.To))
err := replaceValue(strings.Split(mod.FromValuePath, "."), mod.To, chart.Values)

to := mod.To
versionToken := "{.version}"
to = strings.Replace(to, versionToken, c.Version, 1)
err := replaceValue(strings.Split(mod.FromValuePath, "."), to, chart.Values)
if err != nil {
return err
}
Expand Down
Loading