Skip to content

Fixing deadlock in AnalogEQPlot destructor #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Fixing deadlock in AnalogEQPlot destructor #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf456a2
Fixing deadlock in AnalogEQPlot destructor
jatinchowdhury18 Jun 17, 2024
2ed8a06
Merge bf456a262c4900f406f738892333723fa332b3e4 into 3d81f13f0f6809e7f…
jatinchowdhury18 Jun 17, 2024
79be0ce
Apply clang-format
github-actions[bot] Jun 17, 2024
0c25c2f
Fixing include dir
jatinchowdhury18 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
add_subdirectory(JUCE)
add_subdirectory(chowdsp_utils)
add_subdirectory(chowdsp_wdf)
add_subdirectory(eigen)
add_subdirectory(LBFGSpp)

subproject_version(JUCE juce_version)
Expand All @@ -28,7 +27,6 @@ target_link_libraries(juce_plugin_modules
chowdsp::chowdsp_wdf
chowdsp::chowdsp_gui
chowdsp::chowdsp_visualizers
Eigen3::Eigen
lbfgspp
PUBLIC
juce::juce_recommended_config_flags
Expand Down Expand Up @@ -73,6 +71,7 @@ target_compile_definitions(juce_plugin_modules
target_include_directories(juce_plugin_modules
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}/exprtk
${CMAKE_CURRENT_SOURCE_DIR}/eigen
INTERFACE
$<TARGET_PROPERTY:juce_plugin_modules,INCLUDE_DIRECTORIES>
)
Expand Down
2 changes: 1 addition & 1 deletion modules/LBFGSpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ target_include_directories(lbfgspp INTERFACE
# | FIND EXTERNAL LIBRARIES |
# + ----------------------- +

target_link_libraries(lbfgspp INTERFACE Eigen3::Eigen)
#target_link_libraries(lbfgspp INTERFACE Eigen3::Eigen)

# + ------------ +
# | INSTALLATION |
Expand Down
8 changes: 6 additions & 2 deletions src/gui/AnalogEQ/AnalogEQPlot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,12 @@ int AnalogEQPlot::BackgroundPlotter::useTimeSlice()
{
filterPlotter.updateFilterPlot();

juce::MessageManagerLock mml {};
parent.repaint();
juce::MessageManager::callAsync (
[safeParent = juce::Component::SafePointer { &parent }]
{
if (safeParent != nullptr)
safeParent->repaint();
});
}

return 30;
Expand Down
Loading