Fixed ignored invalid field when enum is present (#8026)

Author: faddiv

src/HotChocolate/Core/src/Execution/Processing/VariableCoercionHelper.cs

@@ -173,6 +173,7 @@ private static ObjectValueNode Rewrite(
             {
                 // if we do not find a field on the type we also skip this error and let
                 // the deserialization produce a proper error on this.
+                fields?.Add(current);
                 continue;
             }
 

src/HotChocolate/Core/test/Execution.Tests/Integration/Components/VariableCoercionIntegrationTests.cs

@@ -14,7 +14,8 @@ public async Task Nullables_And_NonNullables_Are_Set()
 
         var user = new ObjectValueNode(
             new ObjectFieldNode("name", "Oliver"),
-            new ObjectFieldNode("surname", "Smith"));
+            new ObjectFieldNode("surname", "Smith"),
+            new ObjectFieldNode("gender", "MALE"));
 
         var request =
             OperationRequestBuilder
@@ -51,7 +52,8 @@ public async Task Nullables_Are_Set_And_NonNullables_Are_Set_To_Null()
 
         var user = new ObjectValueNode(
             new ObjectFieldNode("name", NullValueNode.Default),
-            new ObjectFieldNode("surname", "Smith"));
+            new ObjectFieldNode("surname", "Smith"),
+            new ObjectFieldNode("gender", "MALE"));
 
         var request =
             OperationRequestBuilder
@@ -69,7 +71,8 @@ public async Task Nullables_Are_Set_And_NonNullables_Not_Are_Set()
         var executor = await CreateSchemaAsync();
 
         var user = new ObjectValueNode(
-            new ObjectFieldNode("surname", "Smith"));
+            new ObjectFieldNode("surname", "Smith"),
+            new ObjectFieldNode("gender", "MALE"));
 
         var request =
             OperationRequestBuilder
@@ -147,6 +150,46 @@ public async Task Invalid_Field_Provided()
         await executor.ExecuteAsync(request).MatchSnapshotAsync();
     }
 
+    [Fact]
+    public async Task Invalid_Field_Provided_When_Enum_Is_Present()
+    {
+        var executor = await CreateSchemaAsync();
+
+        var user = new ObjectValueNode(
+            new ObjectFieldNode("name", "Oliver"),
+            new ObjectFieldNode("surname", "Smith"),
+            new ObjectFieldNode("gender", "MALE"),
+            new ObjectFieldNode("foo", "bar"));
+
+        var request =
+            OperationRequestBuilder
+                .New()
+                .SetDocument("mutation($user: UserInput!) { addUser(user: $user) }")
+                .SetVariableValues(new Dictionary<string, object?> { {"user", user }, })
+                .Build();
+
+        await executor.ExecuteAsync(request).MatchSnapshotAsync();
+    }
+
+    [Fact]
+    public async Task Invalid_Enum_Value_Provided()
+    {
+        var executor = await CreateSchemaAsync();
+
+        var user = new ObjectValueNode(
+            new ObjectFieldNode("name", "Oliver"),
+            new ObjectFieldNode("gender", "FOO"));
+
+        var request =
+            OperationRequestBuilder
+                .New()
+                .SetDocument("mutation($user: UserInput!) { addUser(user: $user) }")
+                .SetVariableValues(new Dictionary<string, object?> { {"user", user }, })
+                .Build();
+
+        await executor.ExecuteAsync(request).MatchSnapshotAsync();
+    }
+
     private static async Task<IRequestExecutor> CreateSchemaAsync()
     {
         return await new ServiceCollection()
@@ -160,7 +203,7 @@ public class UserMutation
     {
         public string AddUser(User user)
         {
-            return user.Name + " " + user.Surname + " was added!";
+            return $"{user.Name} {user.Surname} ({user.Gender}) was added!";
         }
     }
 
@@ -181,8 +224,12 @@ public class User(string name)
         public string Name { get; set; } = name;
 
         public string? Surname { get; set; }
+
+        public GenderEnum? Gender { get; set; }
     }
 
+    public enum GenderEnum { Male, Female }
+
     public class UserInputType : InputObjectType<User>
     {
         protected override void Configure(IInputObjectTypeDescriptor<User> descriptor)

src/HotChocolate/Core/test/Execution.Tests/Integration/Components/__snapshots__/VariableCoercionIntegrationTests.Invalid_Enum_Value_Provided.snap

@@ -0,0 +1,15 @@
+{
+  "errors": [
+    {
+      "message": "GenderEnum cannot parse the given literal of type `EnumValueNode`.",
+      "path": [
+        "user",
+        "gender"
+      ],
+      "extensions": {
+        "fieldCoordinate": "UserInput.gender",
+        "fieldType": "GenderEnum"
+      }
+    }
+  ]
+}

src/HotChocolate/Core/test/Execution.Tests/Integration/Components/__snapshots__/VariableCoercionIntegrationTests.Invalid_Field_Provided_When_Enum_Is_Present.snap

@@ -0,0 +1,13 @@
+{
+  "errors": [
+    {
+      "message": "The field `foo` does not exist on the type `UserInput`.",
+      "path": [
+        "user"
+      ],
+      "extensions": {
+        "type": "UserInput"
+      }
+    }
+  ]
+}

src/HotChocolate/Core/test/Execution.Tests/Integration/Components/__snapshots__/VariableCoercionIntegrationTests.Nullables_And_NonNullables_Are_Set.snap

@@ -1,5 +1,5 @@
-{
+{
   "data": {
-    "addUser": "Oliver Smith was added!"
+    "addUser": "Oliver Smith (Male) was added!"
   }
 }

src/HotChocolate/Core/test/Execution.Tests/Integration/Components/__snapshots__/VariableCoercionIntegrationTests.Nullables_Are_Not_Set_NonNullables_Are_Set.snap

@@ -1,5 +1,5 @@
-{
+{
   "data": {
-    "addUser": "Oliver  was added!"
+    "addUser": "Oliver  () was added!"
   }
 }

src/HotChocolate/Core/test/Execution.Tests/Integration/Components/__snapshots__/VariableCoercionIntegrationTests.Nullables_Are_Set_And_NonNullables_Are_Set_To_Null.snap

@@ -1,4 +1,4 @@
-{
+{
   "errors": [
     {
       "message": "Cannot accept null for non-nullable input.",