Combining the CompilationProvider is an anti-pattern, create an IncrementalValueProvider for the assembly name instead. (#8021)

Author: m-gasser

src/HotChocolate/Core/src/Types.Analyzers/Generators/DataLoaderGenerator.cs

@@ -11,7 +11,7 @@ public sealed class DataLoaderGenerator : ISyntaxGenerator
 {
     public void Generate(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
     {
         var dataLoaderDefaults = syntaxInfos.GetDataLoaderDefaults();

src/HotChocolate/Core/src/Types.Analyzers/Generators/DataLoaderModuleGenerator.cs

@@ -10,7 +10,7 @@ public sealed class DataLoaderModuleGenerator : ISyntaxGenerator
 {
     public void Generate(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
     {
         var module = GetDataLoaderModuleInfo(syntaxInfos);

src/HotChocolate/Core/src/Types.Analyzers/Generators/ISyntaxGenerator.cs

@@ -8,6 +8,6 @@ public interface ISyntaxGenerator
 {
     void Generate(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos);
 }

src/HotChocolate/Core/src/Types.Analyzers/Generators/MiddlewareGenerator.cs

@@ -12,15 +12,15 @@ public sealed class MiddlewareGenerator : ISyntaxGenerator
 
     public void Generate(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
     {
         if (syntaxInfos.IsEmpty)
         {
             return;
         }
 
-        var module = syntaxInfos.GetModuleInfo(compilation.AssemblyName, out _);
+        var module = syntaxInfos.GetModuleInfo(assemblyName, out _);
 
         // the generator is disabled.
         if(module.Options == ModuleOptions.Disabled)

src/HotChocolate/Core/src/Types.Analyzers/Generators/TypeModuleSyntaxGenerator.cs

@@ -11,21 +11,21 @@ public sealed class TypeModuleSyntaxGenerator : ISyntaxGenerator
 {
     public void Generate(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
-        => Execute(context, compilation, syntaxInfos);
+        => Execute(context, assemblyName, syntaxInfos);
 
     private static void Execute(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
     {
         if (syntaxInfos.IsEmpty)
         {
             return;
         }
 
-        var module = syntaxInfos.GetModuleInfo(compilation.AssemblyName, out var defaultModule);
+        var module = syntaxInfos.GetModuleInfo(assemblyName, out var defaultModule);
 
         // the generator is disabled.
         if (module.Options == ModuleOptions.Disabled)

src/HotChocolate/Core/src/Types.Analyzers/Generators/TypesSyntaxGenerator.cs

@@ -11,15 +11,15 @@ public sealed class TypesSyntaxGenerator : ISyntaxGenerator
 {
     public void Generate(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
     {
         if (syntaxInfos.IsEmpty)
         {
             return;
         }
 
-        var module = syntaxInfos.GetModuleInfo(compilation.AssemblyName, out _);
+        var module = syntaxInfos.GetModuleInfo(assemblyName, out _);
 
         // the generator is disabled.
         if(module.Options == ModuleOptions.Disabled)

src/HotChocolate/Core/src/Types.Analyzers/GraphQLServerGenerator.cs

@@ -58,7 +58,10 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                 .WithComparer(SyntaxInfoComparer.Default)
                 .Collect();
 
-        var valueProvider = context.CompilationProvider.Combine(syntaxInfos);
+        var assemblyNameProvider = context.CompilationProvider
+            .Select(static (c, _) => c.AssemblyName!);
+
+        var valueProvider = assemblyNameProvider.Combine(syntaxInfos);
 
         context.RegisterSourceOutput(
             valueProvider,
@@ -83,11 +86,9 @@ private static bool Predicate(SyntaxNode node)
 
     private static void Execute(
         SourceProductionContext context,
-        Compilation compilation,
+        string assemblyName,
         ImmutableArray<SyntaxInfo> syntaxInfos)
     {
-        var dictionary = new Dictionary<string, SyntaxInfo>();
-
         foreach (var syntaxInfo in syntaxInfos.AsSpan())
         {
             if (syntaxInfo.Diagnostics.Length > 0)
@@ -101,7 +102,7 @@ private static void Execute(
 
         foreach (var generator in _generators.AsSpan())
         {
-            generator.Generate(context, compilation, syntaxInfos);
+            generator.Generate(context, assemblyName, syntaxInfos);
         }
     }
 }