Skip to content

feat: add minimal support for dall-e generation #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

Granipouss
Copy link

@Granipouss Granipouss commented Jun 11, 2024

image

https://linear.app/literalai/issue/ENG-1534/as-a-ts-sdk-user-i-can-instrument-on-openai-image-generations

Because it doesn't follow either Chat or Completion generation, I used a step, it will hopefully support the future steps easier.

Also We should probably create attachment for output images ?

Also added minimal tests on openai instrumentation

@willydouhard
Copy link
Contributor

great, i'd say the step should be of type tool instead of run though.

@Granipouss
Copy link
Author

great, i'd say the step should be of type tool instead of run though.

A step that has no parent has to be a run apparently

@willydouhard willydouhard merged commit 89badd8 into main Jun 12, 2024
2 checks passed
@willydouhard willydouhard deleted the brendan/openai branch June 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants