feat: add an instrumentation for llama index ts #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Granipouss
force-pushed
the
brendan/eng-1507-llamaindex
branch
from
dfb39b2 to
84e5219
Compare
Granipouss
force-pushed
the
brendan/eng-1507-llamaindex
branch
from
84e5219 to
26595ed
Compare
Dam-Buty
approved these changes
Jun 10, 2024
| export const instrumentLlamaIndex = (client: LiteralClient) => { | ||
| const callbackManager = Settings.callbackManager; | ||
|
|
||
| type LlmCall = { |
There was a problem hiding this comment.
🥜 I have personal beef with types being declared inside of functions 🥊 would you plz consider moving it out ?
There was a problem hiding this comment.
Is it used elsewhere ? What's that beef about ?
There was a problem hiding this comment.
it just feels icky to define types inside functions, although of course it has 0 runtime impact so it's cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc : https://ts.llamaindex.ai/