Skip to content

Python SDK - fix: use promptType and switch llm steps to be run #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

desaxce
Copy link
Contributor

@desaxce desaxce commented Jun 12, 2024

Fixes for the migration:

  • handle the promptType to remap it to a type
  • replace llm to run since we need to pass either messages or prompt for LLM steps

End-to-end tests should pass against the migration branch.

@desaxce desaxce changed the title fix: use promptType and switch llm steps to be run Python SDK fix: use promptType and switch llm steps to be run Jun 12, 2024
@desaxce desaxce changed the title Python SDK fix: use promptType and switch llm steps to be run Python SDK - fix: use promptType and switch llm steps to be run Jun 12, 2024
Copy link
Contributor

@Dam-Buty Dam-Buty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable 👍

@desaxce
Copy link
Contributor Author

desaxce commented Jun 14, 2024

We ended up using a GenerationStep regular Pothos field instead of Step Prisma field in the createGeneration mutation. That way, no need to update our SDKs and we're super safe!
I'll still use this PR to prepare for when we drop GenerationStep from the platform code.

@desaxce desaxce closed this Jun 18, 2024
@desaxce desaxce deleted the hugues/gen-to-step-migration branch July 29, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants