Fixing 'active_steps' getting mixed in async operations #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that some steps were being assigned to the wrong threads, as shown in the screenshot below. After investigating the implementation, I discovered that the
active_steps_var
ContextVar was sometimes being mixed during parallel executions.This issue seems similar to the common Python gotcha where using mutable objects as default values can lead to unexpected behavior. Specifically, it's not safe to use mutable objects as the default value for ContextVars in the current implementation:
Solution
Use a non-mutable default value (such as None) for the ContextVar and provide an empty list when retrieving its value. This approach prevents the mixing of ContextVars during parallel executions.
Code examples