-
-
Notifications
You must be signed in to change notification settings - Fork 411
docs: fix spellcheck errors and improve documentation build consistency (Issue #5045) #8078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
…older structure and markdown files to document SSZ types and utilities. This will serve as a reference for contributors and developers working with Lodestar’s SSZ types
…oofs.md on the readme file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8078 +/- ##
============================================
- Coverage 55.72% 52.19% -3.53%
============================================
Files 834 852 +18
Lines 59754 65054 +5300
Branches 4611 4773 +162
============================================
+ Hits 33299 33958 +659
- Misses 26386 31027 +4641
Partials 69 69 🚀 New features to boost your workflow:
|
…d what they represent
… want to learn more
…as and made a few changes on the styling and arrangement of the docs
…at it is and when is it useful
… real life example and defination of attestation
…fety is implemented and why it matters in the Ethereum Development
…section and the simple definations
…ning from one topic to the other easier
… then polished a few things
…les decided to make the example.md file Having one centralized examples file makes it easy for developers
…pts that are being demonstrated
|
This PR completes the SSZ documentation targeted at TypeScript developers. What's New
|
|
Please lint your work @lolosaisa and thoroughly read the contributor's document to help make CI pass before review, thanks. |
…spell config for docs spellcheck
…mparison - Replaced with to align with Vitest test runner - Updated gitData test to compare branch name and validate commit hash format instead of exact commit value - Ensures consistent test results across commits
|
This PR addresses documentation-related issues and ensures the documentation passes all spellcheck and build requirements. The four failing checks I was working on:
Changes made because kurtosis checks were failing. Updated .wordlist.txt with missing terms and ensured it’s alphabetically sorted. Verified that yarn docs:build and yarn docs:serve work correctly locally. Resolved most unit test timeout issues by adjusting test configuration for CachedBeaconState. Confirmed local documentation now builds and serves without broken links (except one non-critical warning). Notes Only one or two unit tests remain flaky (CachedBeaconState - less 14 validators), likely due to long-running execution time, not logic errors. E2E and sim test failures appear unrelated to these documentation updates. Requesting confirmation from maintainers @philknows if these CI failures could be environmental (e.g., timeouts in workflow runners) rather than code-related. Next steps |
@philknows this focuses only on documentation fixes , updating the spellcheck config, sorting the word list, and verifying the docs build locally. |
This PR adds a rough structure for the SSZ documentation targeted at TypeScript developers, in reference to #5045.
What's included
/packages/types/docs/directory to hold new SSZ usage documentationssz-quickstart.md– Quickstart on serialize/deserialize/hashTreeRootssz-views-and-proofs.md– Overview of views and merkle proofsphase0/Attestation.md,BeaconBlock.md,Validator.mdaltair/SyncCommittee.mdbellatrix/ExecutionPayload.mdREADME.mdoutlining the purpose and structure of the documentationPurpose
This PR is intended to: