Skip to content

Add new tests for update Datacite metadata celery task #11178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/verified-resource-linking
Choose a base branch
from

Conversation

Vlad0n20
Copy link
Contributor

@Vlad0n20 Vlad0n20 commented Jun 9, 2025

Purpose

Changes

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8025?atlOrigin=eyJpIjoiNmQzOThlYzk4OGMyNGJlNDg1NmQ1Mjg5MzM2Y2NiMTMiLCJwIjoiaiJ9

@Vlad0n20 Vlad0n20 force-pushed the feature/ENG-8025 branch from bb13688 to 130a2be Compare June 9, 2025 17:17
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall with one suggestion.

Comment on lines 33 to 37
sentry.log_message(
'DOI metadata with verified links updated for guid',
extra_data={'guid': target_guid},
level=logging.INFO
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, no need to log to sentry on success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants