[ENG-8048] Remove caching to avoid incorrect results for ascendants

[ihorsokhanexoft]

Purpose

When user adds a component to a node that has addons with files and registers it, the node doesn't have any archived files. It happens because the child nodes are the first ones to be registered and if a child doesn't have any addons, this empty list would be saved in request.gv_addons attribute that is reused for all other parents and children to avoid making redundant requests to GV. However each child and parent may have its own collection of addons.

Changes

Removed caching

QA Notes

Would be nice to test what happens when a child node has addons with files, but its parent hasn't. Will the parent inherit archived addons files or not?

Ticket

https://openscience.atlassian.net/browse/ENG-8048?atlOrigin=eyJpIjoiMzk1Yjc2MTIyNzQzNDVmYzg4OGE1ODViYjM1NGEyMWIiLCJwIjoiaiJ9

[adlius]

I don't think the caching done here is affecting how files are archived during the registration workflow. Could you take another look?

[ihorsokhanexoft]

@adlius pushed a new commit. I implemented it in a bit different way. The reason is that the way you suggested doesn't work because this line processes None as request_helpers.get_addon returns it. I compared implementation of _get_addon_from_gv and get_addon_from_gv and they use different functions that pass value to make_ephemeral_node_settings. Maybe they are incompatible and have to be modified.

osf.io/osf/external/gravy_valet/translations.py

Lines 27 to 28 in 2328dd6

	def make_ephemeral_node_settings(gv_addon_data: gv_requests.JSONAPIResultEntry, requested_resource, requesting_user):
	addon_type = gv_addon_data.resource_type.split('-')[1]

I decided to not change the source code and use an additional cached parameter to control caching and separated fetching addons from GV into _get_addons_from_gv_without_caching