[ENG-8223] Fix mfr unittests #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated the same as in WB and not create conflicts on image building, update setup.py to create image without errors
…dd '__init__.py' into tests/core to avoid import errors
…t Exception: (maybe some additional logic is needed for pass and more strict Exception class )
return await aiohttp.request(method, url, *args, **kwargs) osfio-mfr-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ osfio-mfr-1 | TypeError: object _SessionRequestContextManager can't be used in 'await' expression
…eeded to cast to float)
…ed to cast to float)
… be deprecated and need to use template_name)
…t: 'md_globals' and TypeError: 'Registry' object does not support item deletion
and typo in numpy.isscalar
|
Here is an updated branch with all of the recent MFR dep-group updates: https://github.com/CenterForOpenScience/modular-file-renderer/tree/feature/fix-mfr-tests |
…hread'. by removing deprecated get_new_ioloop
…> so needed <tr> are accessed by other indexes
…r-unittests # Conflicts: # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8223
Purpose
MFR has a bunch of failing tests. Let's fix 'em!
If the cause of a test failure turns out to need a big fix, we can create another ticket to track it.
Changes
run pytest to check whether MFR testing is working and update code to be it competable with python3.13
created from the following PR
#381
to keep its changings
Side effects
QA Notes
Deployment Notes