Skip to content

[ENG-7597] 3.2.3 BE: MFR Fix deprecation warnings for py3.13+ #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mkovalua
Copy link

Ticket

https://openscience.atlassian.net/browse/ENG-7597

Purpose

Fix any deprecation warnings for upcoming versions of python. Should pass python compile check, but does not need to pass tests.

Changes

use Qodana code insprect tool to find possible deprecations and code that is needed to be updated

image

Side effects

QA Notes

Deployment Notes

…ke it possible to create image and mfr-requirements, mfr containers for py3.13 without errors
…ssible to build MFR 3.13 image and create containers afterward
@mkovalua
Copy link
Author

FYI: not confident whether it is ok or not

e7be464

image

@mkovalua
Copy link
Author

The same about the following, maybe it is better to keep it as it is for now to not than to refactor. See in code

hasattr(self, 'provider') and so on checking to not access not set variable

image

@mkovalua mkovalua marked this pull request as ready for review April 25, 2025 13:09
@mkovalua
Copy link
Author

mkovalua commented Apr 25, 2025

FYI: Move it to Draft because maybe something is needed to be changed in terms of TODO that is in code and comments

@mkovalua mkovalua marked this pull request as draft April 25, 2025 14:32
@felliott felliott merged commit 87b5366 into CenterForOpenScience:feature/buff-worms Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants