Skip to content

Feature/pbs 25 10 #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 13, 2025
Merged

Feature/pbs 25 10 #2578

merged 13 commits into from
Jun 13, 2025

Conversation

adlius
Copy link
Contributor

@adlius adlius commented Jun 13, 2025

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

aaxelb and others added 12 commits May 6, 2025 16:06
(yet todo: json-ld parsing that would handle either)
[ENG-7937] fix: use compact IRIs to match the api
* Added the files

* Removed tokens

* Updates to display the selected root folder

* Added GFP to the files page

* Updates to add the root folder

* Added the manager to reload the wb once a new file or folder is selected

* Enabled the disabled button featuree again

* Fixed a test

* Updates to the flow for a token from the BE

* Added the final touches and removed pruned instructions

* Updates for the PR

* Updates to move all the google file picker code into the component

* Cleaned up comments and models

* Update for PR request
…bled until oauth token is loaded (#2571)

* Removed a call to a function

* Updates to disable the menu and select folder button until the token is loaded
…mbed

[ENG-8178] remove unnecessary group embed
@coveralls
Copy link

coveralls commented Jun 13, 2025

Pull Request Test Coverage Report for Build 15638683025

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 25 of 82 (30.49%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 67.382%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts 10 13 76.92%
lib/osf-components/addon/components/file-browser/add-new/component.ts 9 15 60.0%
lib/osf-components/addon/components/google-file-picker-widget/component.ts 1 49 2.04%
Files with Coverage Reduction New Missed Lines %
lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts 1 69.32%
lib/osf-components/addon/components/addons-service/manager/component.ts 1 58.05%
lib/osf-components/addon/components/file-browser/add-new/component.ts 1 47.62%
Totals Coverage Status
Change from base Build 15594628874: -0.3%
Covered Lines: 8503
Relevant Lines: 12137

💛 - Coveralls

@adlius adlius merged commit bf5263e into develop Jun 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants