[ENG-7876] Feature/file picker select root #2556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
requested changes
May 2, 2025
There was a problem hiding this comment.
I think we can tidy this up a bit by wrapping most of the stuff in template script tabs int o the Ember component.js file. One you load the https://apis.google.com/js/api.js script via the script tag, you have access to window.gapi and google globally. That means you can do google.picker.DocsView(google.picker.ViewId.FOLDERS) in ember component.ts file and it would work. We can move all the scrip tag logic to component.ts file this way.
futa-ikeda
approved these changes
May 22, 2025
lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts
Outdated
Show resolved
Hide resolved
lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts
Show resolved
Hide resolved
lib/osf-components/addon/components/google-file-picker-widget/component.ts
Outdated
Show resolved
Hide resolved
lib/osf-components/addon/components/google-file-picker-widget/component.ts
Outdated
Show resolved
Hide resolved
lib/osf-components/addon/components/google-file-picker-widget/component.ts
Outdated
Show resolved
Hide resolved
bp-cos
changed the title
adlius
requested changes
May 28, 2025
app/models/authorized-account.ts
Outdated
Comment on lines
35
to
38
| @belongsTo('external-storage-service') | ||
| externalStorageService!: AsyncBelongsTo<ExternalStorageServiceModel> & ExternalStorageServiceModel; | ||
|
|
||
|
|
There was a problem hiding this comment.
Let's not add this to the base model. We should put it back on the AuthorizedStorageAccount model.
brianjgeiger
changed the title
brianjgeiger
changed the title
adlius
approved these changes
May 29, 2025
| @@ -1,4 +1,4 @@ | |||
| import Model, { attr } from '@ember-data/model'; | |||
| import Model, { attr} from '@ember-data/model'; | |||
There was a problem hiding this comment.
Suggested change
| import Model, { attr} from '@ember-data/model'; | |
| import Model, { attr } from '@ember-data/model'; |
adlius
merged commit 73ab56c
into
CenterForOpenScience:feature/pbs-25-10
9 checks passed
adlius
added a commit
that referenced
this pull request
Jun 13, 2025
* fix: use compact IRIs to match the api
(yet todo: json-ld parsing that would handle either)
* fix: IRIs represented as {"@id": "..."}
* (partly) fix types
* [ENG-7876] Feature/file picker select root (#2556)
* Added the files
* Removed tokens
* Updates to display the selected root folder
* Added GFP to the files page
* Updates to add the root folder
* Added the manager to reload the wb once a new file or folder is selected
* Enabled the disabled button featuree again
* Fixed a test
* Updates to the flow for a token from the BE
* Added the final touches and removed pruned instructions
* Updates for the PR
* Updates to move all the google file picker code into the component
* Cleaned up comments and models
* Update for PR request
* do not send initiate_oauth after oauth flow is successful
* fix
* Removed a call to a function
* Added functionality so the GD menu item and select folder are not enabled until oauth token is loaded (#2571)
* Removed a call to a function
* Updates to disable the menu and select folder button until the token is loaded
* remove unnecessary group embed
* Fixed a css issue (#2577)
---------
Co-authored-by: abram axel booth <boothaa@gmail.com>
Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
Co-authored-by: Brian Pilati <brianpilati@cos.io>
Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a new flow to the google drive using the google file picker
Summary of Changes
Add a new component to handle the GFP
Updated the existing code to display the correct components when needed
Screenshot(s)
N/A
Side Effects
Uncertain and could be interesting on how it reacts to other add-ons
QA Notes
Still in the draft phase