Skip to content

[ENG-7712] Fix issue with write users editing registration metadata #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Apr 8, 2025

Purpose

  • Allow write users to update registration metadata without getting yelled at about how "Only admins can edit subjects"

Summary of Changes

  • Remove unnecessary setting of node subjects in the subjects manager
    • This was causing the node's subjects to get included into the PATCH request whenever the subjects::manager component was invoked (which wasn't good when a write-user was viewing a page with it)
    • Remove other unneeded logic that was mucking things up

Screenshot(s)

Side Effects

QA Notes

@futa-ikeda futa-ikeda requested a review from brianjgeiger April 8, 2025 23:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14345867584

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 67.615%

Totals Coverage Status
Change from base Build 14342884383: 0.02%
Covered Lines: 8466
Relevant Lines: 12041

💛 - Coveralls

@brianjgeiger brianjgeiger merged commit 4f96fe2 into CenterForOpenScience:hotfix/25.07.1 Apr 9, 2025
9 checks passed
@futa-ikeda futa-ikeda deleted the write-permission-update branch April 9, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants