[ENG-7739] Add query params for routing #2539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
approved these changes
Apr 3, 2025
There was a problem hiding this comment.
LGTM 🎆
One note: the test failure seems to be trivial which we can fix here or later.
One question: correct me if I am wrong, I think the query param in the URL remains the same if user click other tab and/or choose a different filter. I am fine with this but wondering if it is easy and worthwhile to sync the filter with actions in the page?
adlius
merged commit 017148d
into
CenterForOpenScience:feature/verified-resource-linking
9 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add query params for routing
Summary of Changes
Add query params for routing
Screenshot(s)
N/A
Side Effects
N/A
QA Notes
N/A