Skip to content

First part of improving static code analysis #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

First part of improving static code analysis #117

wants to merge 5 commits into from

Conversation

jakubziebin
Copy link

@jakubziebin jakubziebin commented May 5, 2025 •
edited
Loading

This PR replaces isort, flake8 and black with ruff and introduces pre-commit checks
First part of the: #116

@choinek choinek self-requested a review May 8, 2025 09:51
choinek
choinek requested changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@choinek choinek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this CR! 👍🏻

Could you please add a command to Makefile which will clean the code or at least include instructions how to do it in the readme?

I mean just write down the CLI command which is responsible for running ruff etc. :)

@jakubziebin
Copy link
Author

Readme updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choinek choinek choinek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubziebin @choinek