Skip to content

fix dependency issues and rustc warnings #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 0 additions & 108 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[workspace]
resolver = "2"

members = [

Expand Down
2 changes: 0 additions & 2 deletions crypto/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@ readme = "./README.md"
description = "Utilities for node addressing and message signing in the aleph-bft package."

[dependencies]
async-trait = "0.1"
bit-vec = "0.8"
codec = { package = "parity-scale-codec", version = "3.0", default-features = false, features = ["derive"] }
derive_more = { version = "1.0", features = ["full"] }
log = "0.4"

[dev-dependencies]
tokio = { version = "1", features = ["macros", "rt", "rt-multi-thread"] }
3 changes: 0 additions & 3 deletions crypto/src/signature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ pub trait Keychain: Index + Clone + Send + Sync + 'static {
pub trait PartialMultisignature: Signature {
type Signature: Signature;
/// Adds the signature.
#[must_use = "consumes the original and returns the aggregated signature which should be used"]
fn add_signature(self, signature: &Self::Signature, index: NodeIndex) -> Self;
}

Expand All @@ -65,7 +64,6 @@ pub type SignatureSet<S> = NodeMap<S>;
impl<S: Signature> PartialMultisignature for SignatureSet<S> {
type Signature = S;

#[must_use = "consumes the original and returns the aggregated signature which should be used"]
fn add_signature(mut self, signature: &Self::Signature, index: NodeIndex) -> Self {
self.insert(index, signature.clone());
self
Expand Down Expand Up @@ -398,7 +396,6 @@ impl<T: Signable, MK: MultiKeychain> PartiallyMultisigned<T, MK> {
}

/// Adds a signature and checks if multisignature is complete.
#[must_use = "consumes the original and returns the aggregated signature which should be used"]
pub fn add_signature(self, signed: Signed<Indexed<T>, MK>, keychain: &MK) -> Self {
if self.as_signable().hash().as_ref() != signed.as_signable().hash().as_ref() {
warn!(target: "AlephBFT-signed", "Tried to add a signature of a different object");
Expand Down
2 changes: 0 additions & 2 deletions examples/blockchain/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,5 @@ futures = "0.3"
futures-timer = "3.0"
log = "0.4"
parking_lot = "0.12"
sha3 = "0.10"
time = { version = "0.3", features = ["formatting", "macros", "local-offset"] }
tokio = { version = "1", features = ["macros", "rt", "rt-multi-thread", "io-util", "net", "time"] }
unsigned-varint = { version = "0.8.0", features = ["futures", "asynchronous_codec"] }