Fix nuget package push to github feed #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing mxl comments
Added XML documentation comments to the `AsyncEventHandlerExtensions` class in `AsyncEventHandlerExtensions.cs`, including a summary and remarks section explaining the purpose of the class and its helper functions for running Invoke methods asynchronously. Added XML documentation comments to the `DispatcherTaskExtensions` class in `DispatcherTaskExtensions.cs`, including a summary and remarks section explaining the purpose of the class and its helper functions for running tasks asynchronously on a `CoreDispatcher`. These changes improve code readability and help developers understand the roles of these classes and their methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to improve documentation, update dependencies, and refine code in various files. The most important changes include updating the NuGet setup, adding XML documentation, and refining platform-specific implementations.
Dependency Updates:
.github/workflows/dotnet.yml: UpdatedNuGet/setup-nugetfromv1.1.1tov2and changed the command fromdotnet nuget publishtodotnet nuget push. [1] [2]Documentation Improvements:
src/Caliburn.Micro.Core/AsyncEventHandler.cs: Added XML documentation for theAsyncEventHandlerdelegate.src/Caliburn.Micro.Core/AsyncEventHandlerExtensions.cs: Added XML documentation and remarks for theAsyncEventHandlerExtensionsclass and its methods.src/Caliburn.Micro.Platform/Platforms/net46-netcore/WindowConductor.cs: Added XML documentation for theWindowConductorclass and its methods. [1] [2] [3] [4] [5]Platform-Specific Refinements:
src/Caliburn.Micro.Platform/Platforms/Maui/Windows/MauiPlatformProvider.cs: Updated and corrected XML documentation, refined method implementations, and fixed minor typos. [1] [2] [3] [4] [5] [6]src/Caliburn.Micro.Platform/Platforms/uap/DispatcherTaskExtensions.cs: Added XML documentation and remarks for theDispatcherTaskExtensionsclass and its methods. [1] [2]src/Caliburn.Micro.Platform/Platforms/uap/FrameAdapter.cs: Added XML documentation for theDisposemethod to prevent memory leaks.Code Refinements:
src/Caliburn.Micro.Platform/Platforms/net46-netcore/FrameAdapter.cs: Added XML documentation for theDisposemethod to prevent memory leaks.Closes #910
Closes #909