Fix issue #906 #907
Merged
Fix issue #906 #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiveItem underlying field synchronously
vb2ae
reviewed
Oct 26, 2024
…ore setting ActiveItem backing field
|
pr #891 is merged in can you merge or rebase this to the latest in the master branch? I will approve and merge in |
…tiveItem underlying field synchronously
…ore setting ActiveItem backing field
…ithub.com/darxis/Caliburn.Micro into async-calls-in-ondeactivateasync-bugfix-1
vb2ae
approved these changes
Nov 3, 2024
|
@darxis thanks It is merged in. I need to make a few changes to the build github action. Did not think about setting up the github feed credentials in the build from a fork would fail because the secrets are not available |
|
@vb2ae Thanks. Can we make a new v4 release with this bugfix? I am still using v4 and it would be nice to have it fixed in as v4 (v4.0.213?) as v5 is still in beta. |
|
There is 4.0.212 branch we can merge your fix into. Not sure it will build because it uses some unsuported platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #906. Please review.