Update PasswordManagementTrait.php #1125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix password reset flow: redirect to login action if no user is found.
|
Hi @sharkooon, thanks for your contribution. Could you please take a look to the checks failing? Basically a missing line before return statement and also some tests failing because the response code (302 - redirect) does not match the previous one (200) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix password reset flow: redirect to login action if no user is found.
An issue in the password reset flow where the application would not properly handle cases when no user is found.
By redirecting to the login screen when no user is found, we enhance security and user experience. Previously, the application would remain on the reset password form, which could inadvertently reveal whether a user exists or not based on the action taken.