-
Couldn't load subscription status.
- Fork 382
Add Basic Materials Functionality #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
+ Coverage 95.74% 95.82% +0.07%
==========================================
Files 29 29
Lines 7827 7943 +116
Branches 1179 1202 +23
==========================================
+ Hits 7494 7611 +117
Misses 192 192
+ Partials 141 140 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the intent of this PR correctly, you actually want to use XCAFDoc_Material
|
@adam-urbanczyk I need to better understand what you are thinking. The current |
|
In the end this class should wrap NB: it can be used for now to simply store a name. |
|
@adam-urbanczyk How about this? |
This is a smaller PR which wraps
Graphic3d_MaterialAspectXCAFDoc_MaterialandXCAFDoc_VisMaterialfrom OCC and leaves open the possibility of adding inphysicalvisualization properties later.