Skip to content

Added tagging of parts within assemblies #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Added tagging of parts within assemblies #9

merged 2 commits into from
Mar 28, 2025

Conversation

jmwright
Copy link
Member

@shimwell This is a first attempt at adding volume tagging to the mesh exporter. I'm looking for some feedback. There are two things to note.

  1. The current tagging method uses the name of the part in the assembly to tag the volumes. Should explicit tagging be used instead (or in addition to)?
  2. The feature is currently on all the time, causing the resulting .msh files to have extra physical groups for the part volumes. Will this cause problems? If so, I can make it a parameter.

@shimwell
Copy link
Collaborator

use of name is fine with me. These names have to be unique so I would perhaps rename them later in the workflow.

For example there might be volumes called magnet1, magnet2, magnet3 but all of these would be made from the same material. So later in my workflow I would map to use a single material name.

But I think use of name is good with me.

Always on behavior and extra physical groups is also fine with me.

@jmwright jmwright marked this pull request as ready for review March 25, 2025 17:10
@jmwright
Copy link
Member Author

Ok, I'll leave this open for two days or so, and then merge if there's no other comments.

@jon-proximafusion
Copy link

@RemDelaporteMathurin @jhdark does having tagged volumes in the gmsh object help your workflows for FESTIM

@RemDelaporteMathurin
Copy link

@jon-proximafusion well I believe this would help yes. I believe so far I've always tagged volumes and surfaces manually in GMSH with selectors (ie. is the surface near x=3, etc).

@jmwright jmwright merged commit 7729a5b into main Mar 28, 2025
6 checks passed
@jmwright jmwright deleted the solid_tagging branch March 28, 2025 12:22
@jmwright jmwright restored the solid_tagging branch March 28, 2025 12:22
@jmwright jmwright deleted the solid_tagging branch April 30, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants