Skip to content

Added Mode Toggler #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

VijaySamant4368
Copy link

Related Issue

#560

Description

Made the mode toggler with SVG images that changes based on the mode.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Uploading Screen Recording 2024-07-19 201325.mp4…

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

This pr is under GSSoC 2024. Please label it with appropriate labels.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@VijaySamant4368
Copy link
Author

@CSEdgeOff please review and merge this pr

@Durgesh-Vaigandla
Copy link
Contributor

@VijaySamant4368 Add the screenshots of the outputs in different views

@VijaySamant4368
Copy link
Author

After that small change, the Screenshots would be as follows:

At full screen
image

Width 1500px
image

Width 1000px
image

Width 500px
image

Width 300px
image

Although making it responsive for even smaller screen width is unnecessary, I can make it responsive, but I would have to change the other parts of the source-code.

@VijaySamant4368
Copy link
Author

@Durgesh-Vaigandla, please kindly check.

@Durgesh-Vaigandla
Copy link
Contributor

@VijaySamant4368 in mobile view incorporate the button inside the navbar I mean if the nav is open the button would display

@Durgesh-Vaigandla Durgesh-Vaigandla added the gssoc Girl Script Summer of Code 2024 label Jul 19, 2024
@VijaySamant4368
Copy link
Author

@Durgesh-Vaigandla, do you mean that I have to add the Toggle-Button in the drop down menu?
"If the user press the three lines(hamburger) button, then only the Toggle Mode should show" Is this what you mean?

@Durgesh-Vaigandla
Copy link
Contributor

@VijaySamant4368 yeah exactly

@VijaySamant4368
Copy link
Author

@Durgesh-Vaigandla it may take some time.

@VijaySamant4368
Copy link
Author

Should I make it such that it is outside till the width is say 500px, but if it is less than that, it goes inside.
As the nav-bar would have a lot of empty space.
@Durgesh-Vaigandla

@VijaySamant4368
Copy link
Author

@Durgesh-Vaigandla will these suffice?

For width less than 1100px, it is still same

The nav-Bar
image

Inside Hamburger
image
Pressing the 'Toggle Mode' toggles the mode and closes the hamburger.

@VijaySamant4368
Copy link
Author

@Durgesh-Vaigandla please label this as GSSoC Level 3

@VijaySamant4368
Copy link
Author

@Durgesh-Vaigandla @CSEdgeOff please kindly checkout this pr

@github-actions github-actions bot closed this Aug 27, 2024
Copy link

This issue has been automatically closed because it has been inactive for more than 30 days. If you believe this is still relevant, feel free to reopen it or create a new one. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants