-
Notifications
You must be signed in to change notification settings - Fork 125
Added Mode Toggler #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mode Toggler #572
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@CSEdgeOff please review and merge this pr |
@VijaySamant4368 Add the screenshots of the outputs in different views |
@Durgesh-Vaigandla, please kindly check. |
@VijaySamant4368 in mobile view incorporate the button inside the navbar I mean if the nav is open the button would display |
@Durgesh-Vaigandla, do you mean that I have to add the Toggle-Button in the drop down menu? |
@VijaySamant4368 yeah exactly |
@Durgesh-Vaigandla it may take some time. |
Should I make it such that it is outside till the width is say 500px, but if it is less than that, it goes inside. |
@Durgesh-Vaigandla will these suffice? For width less than 1100px, it is still same Inside Hamburger |
@Durgesh-Vaigandla please label this as GSSoC Level 3 |
@Durgesh-Vaigandla @CSEdgeOff please kindly checkout this pr |
This issue has been automatically closed because it has been inactive for more than 30 days. If you believe this is still relevant, feel free to reopen it or create a new one. Thank you! |
Related Issue
#560
Description
Made the mode toggler with SVG images that changes based on the mode.
Type of PR
Screenshots / videos (if applicable)
Uploading Screen Recording 2024-07-19 201325.mp4…
Checklist:
Additional context:
This pr is under GSSoC 2024. Please label it with appropriate labels.