Skip to content

INTAKE_Fig12-ZonelTempSalt #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 5, 2025

Hi @charles-turner-1

I found out that @max-anu had converted that one.
Can you review please?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -2,6 +2,7 @@
"cells": [
Copy link
Collaborator

@charles-turner-1 charles-turner-1 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could probably speed this up a good bit by providing some sensible chunking.


Reply via ReviewNB

@@ -2,6 +2,7 @@
"cells": [
Copy link
Collaborator

@charles-turner-1 charles-turner-1 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #3.    ds = xr.open_mfdataset('/g/data/ik11/observations/woa13/01/woa13_ts_??_mom01.nc',chunks=woa_chunks)

We can get rid of this open_mfdataset call once we have the esmvaltool-obs dataset in the catalog right?


Reply via ReviewNB

@charles-turner-1
Copy link
Collaborator

I think we can clean this up a bit - especially related to chunking, etc. Jumping in now

@charles-turner-1
Copy link
Collaborator

charles-turner-1 commented Jun 6, 2025

@rbeucher It seems this experiment is no longer in the catalog.

Presumably the paper we are reproducing figures from is this one?.

Would @aekiss or @AndyHoggANU be the right people to ask about whether we would expect this experiment to still be in the catalog & if not what it wants replacing with?

Screenshot 2025-06-06 at 8 15 31 am

EDIT: Anyone looking at this far in the future will notice that I accidentally put the string 'expt' in, not the actual experiment.

Doesn't change the result:
Screenshot 2025-06-06 at 9 16 58 am

@AndyHoggANU
Copy link
Contributor

Yeah, that is the right paper but the experiments are quite old. So, we don't expect to replicate the actual figure, just the method to find it, and importantly that it includes 3 different experiments - one at each resolution. You'll see we picked three relevant experiments for the other recipes in this directory (e.g. Fig. 3):

'1deg_jra55_iaf_omip2_cycle?'
'025deg_jra55_iaf_omip2_cycle?'
01deg_jra55v140_iaf.*'

I would just use them, and choose the same time period (1993-2017) for the 4th cycle ....

@aekiss
Copy link
Contributor

aekiss commented Jun 6, 2025

FYI details on current control experiments are here https://forum.access-hive.org.au/t/access-om2-control-experiments/258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants