Convert Meridional Heat Transport to Intake #517
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -6,21 +6,13 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
diff
-We are now ready to query the database and load the data to start our analysis.
+We are now ready to load the data to start our analysis.
Reply via ReviewNB
| @@ -6,21 +6,13 @@ | |||
| "source": [ | |||
There was a problem hiding this comment.
The green & blue lines (the heat fluxes we've computed here) have changed. It looks like at ~40S we're seeing a northward heat transport for a few degrees, which is different to before and almost certainly not right.
The green line has also shifted, although I'm less concerned by it - it looks like numerics to me - but we definitely need to work out why these have changed.
Reply via ReviewNB
There was a problem hiding this comment.
It's not the same experiment @charles-turner-1
There was a problem hiding this comment.
I had to change it.
There was a problem hiding this comment.
ahh, that makes sense. I'm still kinda concerned about the northward heat transport at 40S so I'll comb through it carefully, but fingers crossed it's just that.
|
ReviewNB has bungled the alignment, so I can't quite tell precisely what's changed, but there are definitely some issues with the updated calculations. Gonna dig into this a bit more deeply. |
That's because I got rid of method 3. See comments in #450 |
|
@rbeucher had a couple of issues with the chunking (I actually couldn't run the recipe) & I've replaced a workaround with a direct coordinate search. I'm satisfied that northward heat transport is just a quirk of the model run & not any sort of issue with the calculation. Ready to ship, if you're happy with my changes |
|
Go for it 🎉 |
The following issues seemed to have previously been addressed:
close #321