-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/overflows #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/overflows #609
Conversation
Fix/overflows2
Duplicate/overflows2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Develop #609 +/- ##
==========================================
+ Coverage 4.65% 5.57% +0.91%
==========================================
Files 133 134 +1
Lines 7902 8330 +428
==========================================
+ Hits 368 464 +96
- Misses 7534 7866 +332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all good on my side thank you for your hard work on this Monika! You really did some good work for us. It does not go unnoticed. If anything else pops up we will tackle it together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No overflows!
I am kind of hoping this has fixed all the overflow issues. Please ensure you have the newest code on your side. If there are still some overflows then I do not know what to do. However I feel if Franco's code comes in , those last few overflows should be fixed. I tested everything with a screen width of 320.