Skip to content

Conversation

MonikaTheiss
Copy link
Contributor

I am kind of hoping this has fixed all the overflow issues. Please ensure you have the newest code on your side. If there are still some overflows then I do not know what to do. However I feel if Franco's code comes in , those last few overflows should be fixed. I tested everything with a screen width of 320.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 15.28998% with 482 lines in your changes missing coverage. Please review.

Project coverage is 5.57%. Comparing base (0135a98) to head (edf33a6).
Report is 29 commits behind head on Develop.

Files with missing lines Patch % Lines
lib/view/pages/events/create_events_page.dart 0.00% 131 Missing ⚠️
lib/view/components/home/start_timer.dart 0.00% 68 Missing ⚠️
lib/view/pages/events/edit_event_page.dart 0.00% 62 Missing ⚠️
lib/view/components/stats/total_time_boxes.dart 0.00% 56 Missing ⚠️
lib/view/components/home/event_invite.dart 0.00% 50 Missing ⚠️
lib/view/pages/home/home_page.dart 0.00% 38 Missing ⚠️
lib/view/pages/events/view_events_page.dart 0.00% 35 Missing ⚠️
lib/view/components/events/joined_event_card.dart 0.00% 14 Missing ⚠️
lib/view/components/profile/activity_card.dart 0.00% 7 Missing ⚠️
lib/view/components/events/create_event_chips.dart 0.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           Develop    #609      +/-   ##
==========================================
+ Coverage     4.65%   5.57%   +0.91%     
==========================================
  Files          133     134       +1     
  Lines         7902    8330     +428     
==========================================
+ Hits           368     464      +96     
- Misses        7534    7866     +332     
Flag Coverage Δ
5.57% <15.28%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pieryvdl pieryvdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good on my side thank you for your hard work on this Monika! You really did some good work for us. It does not go unnoticed. If anything else pops up we will tackle it together.

Copy link
Contributor

@shan-226 shan-226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No overflows!

@MonikaTheiss MonikaTheiss merged commit 188039c into Develop Sep 25, 2024
4 checks passed
@MonikaTheiss MonikaTheiss deleted the fix/overflows branch September 28, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants