-
Notifications
You must be signed in to change notification settings - Fork 1
added performance to the app #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Develop #607 +/- ##
==========================================
- Coverage 4.65% 4.65% -0.01%
==========================================
Files 133 133
Lines 7902 7911 +9
==========================================
Hits 368 368
- Misses 7534 7543 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, not too many changes. Just a small question, I am approving this anyway , I just wanted to double check.. why exactly do we need this on our (future) apk's? Will this help us to see what is going on on other people's phones?
So this will help to track to performance on our app in terms of response times, so if we add it, can can see typically how fast the queries to firebase and to the RAWG Api are. We can also see on average how long it takes to load the home screen etc. And to answer your question, yes it not only picks up for one account, but once this is in the main app any version after that will send us feedback. Or at least that's how I understand it. |
Oh thats great !!! Well done on figuring this out ! |
Once this has been merged in, or when i have the time, I will try to add more traces so that we can monitor more requests and so forth. |
Hey guys we should get this into Develop asap, it is performance testing for the app, so when you run the app it measures performance, You can check Firebase, thanks.
if you guys have any questions let me know... the custom traces are tracking the time it takes for the requests to return.