Skip to content

Conversation

pieryvdl
Copy link
Contributor

Hey guys we should get this into Develop asap, it is performance testing for the app, so when you run the app it measures performance, You can check Firebase, thanks.

if you guys have any questions let me know... the custom traces are tracking the time it takes for the requests to return.

@pieryvdl pieryvdl added enhancement New feature or request Testing labels Sep 25, 2024
@pieryvdl pieryvdl added this to the Demo_4 milestone Sep 25, 2024
@pieryvdl pieryvdl self-assigned this Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 4.65%. Comparing base (0135a98) to head (800560c).
Report is 2 commits behind head on Develop.

Files with missing lines Patch % Lines
lib/services/game_library_S/game_service.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           Develop    #607      +/-   ##
==========================================
- Coverage     4.65%   4.65%   -0.01%     
==========================================
  Files          133     133              
  Lines         7902    7911       +9     
==========================================
  Hits           368     368              
- Misses        7534    7543       +9     
Flag Coverage Δ
4.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MonikaTheiss MonikaTheiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, not too many changes. Just a small question, I am approving this anyway , I just wanted to double check.. why exactly do we need this on our (future) apk's? Will this help us to see what is going on on other people's phones?

@pieryvdl
Copy link
Contributor Author

pieryvdl commented Sep 25, 2024

So this will help to track to performance on our app in terms of response times, so if we add it, can can see typically how fast the queries to firebase and to the RAWG Api are. We can also see on average how long it takes to load the home screen etc. And to answer your question, yes it not only picks up for one account, but once this is in the main app any version after that will send us feedback. Or at least that's how I understand it.

@MonikaTheiss
Copy link
Contributor

So this will help to track to performance on our app in terms of response times, so if we add it, can can see typically how fast the queries to firebase and to the RAWG Api are. We can also see on average how long it takes to load the home screen etc. And to answer your question, yes it not only picks up for one account, but once this is in the main app any version after that will send us feedback. Or at least that's how I understand it.

Oh thats great !!! Well done on figuring this out !

@pieryvdl
Copy link
Contributor Author

So this will help to track to performance on our app in terms of response times, so if we add it, can can see typically how fast the queries to firebase and to the RAWG Api are. We can also see on average how long it takes to load the home screen etc. And to answer your question, yes it not only picks up for one account, but once this is in the main app any version after that will send us feedback. Or at least that's how I understand it.

Once this has been merged in, or when i have the time, I will try to add more traces so that we can monitor more requests and so forth.

@pieryvdl pieryvdl merged commit 9f1731b into Develop Sep 25, 2024
3 of 4 checks passed
@pieryvdl pieryvdl deleted the feat/performanceintegration branch September 27, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants