Skip to content

Conversation

pieryvdl
Copy link
Contributor

Hey guys, some more fixes and features here:

  1. Forgot password now works! You can test it by logging out and checking your email after you've sent a request.
  2. Removed the duplicate Gaming session/tournament on the create event page
  3. I added a label to the bottom of the stats pages to indicate that it is games
  4. Added Android permissions asking when selecting images for the profile in customize profile.
  5. Wrapped the settings page in a scrollable widget.

Let me know what you guys think!

@pieryvdl pieryvdl added backend Any backend for the project frontend Frontend development of the project labels Sep 24, 2024
@pieryvdl pieryvdl added this to the Demo_4 milestone Sep 24, 2024
@pieryvdl pieryvdl self-assigned this Sep 24, 2024
@pieryvdl pieryvdl linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 43.44262% with 69 lines in your changes missing coverage. Please review.

Project coverage is 4.67%. Comparing base (fe902af) to head (f377f4b).
Report is 14 commits behind head on Develop.

Files with missing lines Patch % Lines
lib/view/pages/authentication/login_page.dart 10.00% 54 Missing ⚠️
lib/view/pages/settings/settings_page.dart 78.33% 13 Missing ⚠️
lib/services/authentication_S/auth_service.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           Develop    #598      +/-   ##
==========================================
+ Coverage     4.65%   4.67%   +0.02%     
==========================================
  Files          131     131              
  Lines         7797    7824      +27     
==========================================
+ Hits           363     366       +3     
- Misses        7434    7458      +24     
Flag Coverage Δ
4.67% <43.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pieryvdl pieryvdl linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Contributor

@MonikaTheiss MonikaTheiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done ! Everything looks good on my side, thank you 😄

Copy link
Contributor

@shan-226 shan-226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reset password works!

@u22520016
Copy link
Contributor

For some reason, I cannot run this specific branch on my device and don't know how to fix it...

Screenshot 2024-09-24 at 17 12 09

@pieryvdl
Copy link
Contributor Author

@u22520016 try running "flutter clean" and then "flutter pub get" in your terminal and then running it a few times. It sometimes needs to clear the cache, before the code works. Not sure why, but it seems to work.

@u22520016
Copy link
Contributor

@u22520016 try running "flutter clean" and then "flutter pub get" in your terminal and then running it a few times. It sometimes needs to clear the cache, before the code works. Not sure why, but it seems to work.

I tried this but it still does not work. I don't know what to do about it...

@pieryvdl
Copy link
Contributor Author

Maybe try, "flutter upgrade" after you flutter pub get as there is a few new packages in the branch as well. I just ran the branch on my side again and it seems to be working, will have a look again and if there is something else I can fix.

@u22520016
Copy link
Contributor

I did everything. Nothing works...let's wait for Lerato to approve

@pieryvdl
Copy link
Contributor Author

pieryvdl commented Sep 24, 2024

Cool. Just to confirm are you running it on web?

@pieryvdl
Copy link
Contributor Author

pieryvdl commented Sep 24, 2024

//leave the 2 lines above this comment in the file and just add the lines below this comment:
flutter.buildMode=debug
flutter.versionName=1.0.0
flutter.versionCode=1

flutter.minSdkVersion=23
flutter.targetSdkVersion=34
flutter.compileSdkVersion=34

@franco please copy the above lines and put it inside android>local.properties file... This should make the branch run on your side, I completely forgot that that file is being ignored and explains why the branch is not working for you. Sorry this is my bad. Thank you to @MonikaTheiss for reminding me.
Also @shan-226 and @LeratoKgomo you would need to do this too for it to work.

@pieryvdl pieryvdl merged commit 6bfa26e into Develop Sep 24, 2024
4 checks passed
@pieryvdl pieryvdl deleted the fix/bugsandforgotpassword branch September 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Any backend for the project frontend Frontend development of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permissions asker Add forgot password functionality

4 participants