-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/specific badge page #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Develop #585 +/- ##
==========================================
- Coverage 4.65% 4.63% -0.02%
==========================================
Files 133 133
Lines 7822 7848 +26
==========================================
Hits 364 364
- Misses 7458 7484 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Franco, this looks brilliant! I think we get this with the actual data it will look sooo cool. Thanks for getting the design in. The alignment of the loyalty badge is the wrong way around but the rest looks good thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This is the STATIC page for the specific badge page. It contains only mock data, but I implemented the design so long. Yes, I am aware that the badges are not yet imported in the app. I wanted to use mock data first. Click on loyalty or gamer badge to test.