Skip to content

Conversation

u22520016
Copy link
Contributor

This is the STATIC page for the specific badge page. It contains only mock data, but I implemented the design so long. Yes, I am aware that the badges are not yet imported in the app. I wanted to use mock data first. Click on loyalty or gamer badge to test.

@u22520016 u22520016 self-assigned this Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 4.63%. Comparing base (619f342) to head (7d5274b).
Report is 23 commits behind head on Develop.

Files with missing lines Patch % Lines
lib/view/pages/badges/badge_page.dart 0.00% 30 Missing ⚠️
lib/view/pages/badges/achievement_badges.dart 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           Develop    #585      +/-   ##
==========================================
- Coverage     4.65%   4.63%   -0.02%     
==========================================
  Files          133     133              
  Lines         7822    7848      +26     
==========================================
  Hits           364     364              
- Misses        7458    7484      +26     
Flag Coverage Δ
4.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pieryvdl pieryvdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Franco, this looks brilliant! I think we get this with the actual data it will look sooo cool. Thanks for getting the design in. The alignment of the loyalty badge is the wrong way around but the rest looks good thank you!

Copy link
Contributor

@shan-226 shan-226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@u22520016 u22520016 merged commit 44eb06a into Develop Sep 24, 2024
2 of 4 checks passed
@u22520016 u22520016 deleted the feat/SpecificBadgePage branch September 29, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants