Skip to content

Bounds value fixes for VP and BP #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Bounds value fixes for VP and BP #294

merged 2 commits into from
Apr 9, 2025

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Apr 5, 2025

ClimaVue documentation:

Screenshot 2025-04-05 at 07 34 35

From this I think that VP bounds should be 0 to 470 mbar (=0 to 47 kPa) and BP bounds 50,000 to 110,000 mbar (=500 to 1100 hPa = 5000 to 11000 kPa).

Screenshot 2025-04-05 at 07 31 55

@roylrich Please double-check

Addresses #283

@bpbond bpbond linked an issue Apr 5, 2025 that may be closed by this pull request
@bpbond bpbond changed the title Bound value changes for VP and BP Bounds value fixed for VP and BP Apr 5, 2025
@bpbond bpbond changed the title Bounds value fixed for VP and BP Bounds value fixes for VP and BP Apr 5, 2025
@bpbond
Copy link
Member Author

bpbond commented Apr 9, 2025

I asked @wilsonsj100 to look at this and she thinks everything looks good. Thank you!

@bpbond bpbond merged commit 7a7955f into dev-v2 Apr 9, 2025
1 check passed
@bpbond bpbond deleted the vp branch April 9, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClimaVue50 vapor pressure units are inconsistent
1 participant