Update unsequa tutos #1107
Update unsequa tutos #1107
Conversation
luseverin
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
| sampled. For example, Hazards outputs from dynamical models | ||
| for different input factors. | ||
| Uniformly sample one element from the provided list of hazards. | ||
| For example, Hazards outputs from dynamical models for different input factors. |
There was a problem hiding this comment.
This would be incorrect phrasing. In general, more than one sample is drawn in total, althought for each global sample, one element is chosen. Maybe ?
Hazard is uniformly sampled the provided list of hazards.
There was a problem hiding this comment.
I have rephrased so that this is clearer.
| "| param_labels | list(str) | Name of all the uncertainty input parameters|\n", | ||
| "| problem_sa | dict | The description of the uncertainty variables and their distribution as used in [SALib](https://salib.readthedocs.io/en/latest/basics.html). |\n", | ||
| "| sensitivity_method | str | Sensitivity analysis method from [SALib.analyse](https://salib.readthedocs.io/en/latest/api.html) Possible choices: 'fast', 'rbd_fact', 'morris', 'sobol', 'delta', 'ff'. Note that in Salib, sampling methods and sensitivity analysis methods should be used in specific pairs.|\n", | ||
| "| sensitivity_method | str | Sensitivity analysis method from [SALib.analyse](https://salib.readthedocs.io/en/latest/api.html) Possible choices: 'sobol', 'fast', 'rbd_fast', 'morris', 'dgsm', 'ff', 'pawn', 'rhdm', 'rsa', 'discrepancy', 'hdmr'. Note that in Salib, sampling methods and sensitivity analysis methods should be used in specific pairs.|\n", |
There was a problem hiding this comment.
I do not see it in this PR, but where the allowed pairing options updated in the respective .py files?
There was a problem hiding this comment.
Yes, they are up to date. I think this was done in the unsequa update PR but I forgot to update this tutorial back then.
|
Thanks for the update! I am not sure that the new sampling formulation is correct, as to me it suggest that a single sample is drawn, which is incorrect. |
Changes proposed in this PR:
Only minor changes here (typos, updating links and refs), although some things in climada_engine_unsequa were broken (e.g. linked to the data API).
PR Author Checklist
develop)PR Reviewer Checklist